Repository navigation
Fix JSON login prompts, secure publication URLs, and restore shell completions - #126
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
JSON login can prompt, completions can disappear behind suppressed Console output, and terminal write failures can report success. Publication discovery can also direct an authenticated upload to an arbitrary URL.
skit --json auth loginnoninteractive without consulting unrelated process arguments.Only CLI files change. Author commands, watchers and authored installation remain on the separate author-sync branch. Existing contract IDs are unchanged.
Call graphs
Compared revisions: base
e25928d888cf884d9e8602c0313e5b893bdbc208, final9a2c62d3df062fafbdee46e5c8a5a55e484bef67. Condensed graphs omit formatting and transport error classification; writer/storage ownership is unchanged.Effect retains argument validation, help construction and completion generation; Renderer retains envelopes, status lifecycle and exit presentation. No new service or general parser. The early output selector mirrors installed Boolean literals, verified against real Effect parsing, because synchronous literal predicates are internal. The explicit protocol check excludes
blob:https://…URLs that can share an HTTPS origin.Validation
Local evidence:
Destination tests prove through a dummy HTTP client that rejected URLs receive no authenticated upload. Redirect coverage checks upload transport configuration and rejection response, not a live redirect server. Terminal failure coverage injects a callback error into the real executable, not a real OS EPIPE trial.
Full workspace/server suites were not run. Remote CI, deployment and live publication remain unverified.