Repository navigation
Upgrade better-auth to 1.7.18 - #122
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better Auth 1.7.3+ no longer writes
account.issuer, so upgrading SKIT's 1.7.1 dependency alone would break sign-up and account linking against its required issuer column. Upgrade Better Auth and its bundled adapters to 1.7.18, migrate account keys to(providerId, accountId), and update bootstrap to write the current schema.Migration 0011 creates the new unique index before dropping the issuer index and column, refusing ambiguous existing identities without deleting accounts. Remove the obsolete Vitest 5 peer patch and exception, and update the readiness migration manifest.
Validation: server/web typechecks, server/client production build, 46 focused Cloudflare runtime tests across five files, changed-file lint/format checks, and frozen installation with supply-chain checks passed locally. Migration tests cover existing-account password sign-in, preserved account data, cross-provider IDs, and duplicate-key refusal. CI and live deployment are unverified.
Deployment must coordinate migration 0011 with the new Worker: old 1.7.1 code still writes issuer. Upstream OAuth state changes also require restarting in-flight sign-ins and upgrading servers sharing auth state together. See the upstream upgrade guide.