Searching for multi-byte utf-8 characters in the minibuffer results in a panic #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

sminez merged 4 commits into develop from issue-123

Jun 1, 2025

Merged

Searching for multi-byte utf-8 characters in the minibuffer results in a panic #128

move allowing unicode bidi codepoints to the crate level

GitHub Actions / clippy succeeded Jun 1, 2025 in 0s

clippy

11 warnings

Details

Results

Message level	Amount
Internal compiler error	0
Error	0
Warning	11
Note	0
Help	0

Versions

rustc 1.87.0 (17067e9ac 2025-05-09)
cargo 1.87.0 (99624be96 2025-05-06)
clippy 0.1.87 (17067e9ac6 2025-05-09)

Annotations

Check warning on line 69 in src/lsp/client.rs

github-actions / clippy

this can be `std::io::Error::other(_)`

warning: this can be `std::io::Error::other(_)`
  --> src/lsp/client.rs:69:32
   |
69 |                     return Err(io::Error::new(io::ErrorKind::Other, e));
   |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
note: the lint level is defined here
  --> src/lib.rs:5:5
   |
5  |     clippy::style,
   |     ^^^^^^^^^^^^^
   = note: `#[warn(clippy::io_other_error)]` implied by `#[warn(clippy::style)]`
help: use `std::io::Error::other`
   |
69 -                     return Err(io::Error::new(io::ErrorKind::Other, e));
69 +                     return Err(io::Error::other(e));
   |

Check warning on line 32 in benches/benchmarks/rsc_pathological_regex.rs

github-actions / clippy

use of deprecated function `criterion::black_box`: use `std::hint::black_box()` instead

warning: use of deprecated function `criterion::black_box`: use `std::hint::black_box()` instead
  --> benches/benchmarks/rsc_pathological_regex.rs:32:41
   |
32 |         b.iter(|| assert!(r.matches_str(black_box(&s))))
   |                                         ^^^^^^^^^

Check warning on line 27 in benches/benchmarks/rsc_pathological_regex.rs

github-actions / clippy

use of deprecated function `criterion::black_box`: use `std::hint::black_box()` instead

warning: use of deprecated function `criterion::black_box`: use `std::hint::black_box()` instead
  --> benches/benchmarks/rsc_pathological_regex.rs:27:41
   |
27 |         b.iter(|| rsc_pathological_case(black_box(100)))
   |                                         ^^^^^^^^^

Check warning on line 7 in benches/benchmarks/rsc_pathological_regex.rs

github-actions / clippy

use of deprecated function `criterion::black_box`: use `std::hint::black_box()` instead

warning: use of deprecated function `criterion::black_box`: use `std::hint::black_box()` instead
 --> benches/benchmarks/rsc_pathological_regex.rs:7:17
  |
7 | use criterion::{black_box, criterion_group, criterion_main, Criterion};
  |                 ^^^^^^^^^

Check warning on line 43 in benches/benchmarks/burntsushi_torture_regex.rs

github-actions / clippy

use of deprecated function `criterion::black_box`: use `std::hint::black_box()` instead

warning: use of deprecated function `criterion::black_box`: use `std::hint::black_box()` instead
  --> benches/benchmarks/burntsushi_torture_regex.rs:43:41
   |
43 |         b.iter(|| assert!(r.matches_str(black_box(&s))))
   |                                         ^^^^^^^^^

Check warning on line 38 in benches/benchmarks/burntsushi_torture_regex.rs

github-actions / clippy

use of deprecated function `criterion::black_box`: use `std::hint::black_box()` instead

warning: use of deprecated function `criterion::black_box`: use `std::hint::black_box()` instead
  --> benches/benchmarks/burntsushi_torture_regex.rs:38:67
   |
38 |         b.iter(|| burntsushi_pathological_case(black_box(n_alts), black_box(n_reps)))
   |                                                                   ^^^^^^^^^

Check warning on line 38 in benches/benchmarks/burntsushi_torture_regex.rs

github-actions / clippy

use of deprecated function `criterion::black_box`: use `std::hint::black_box()` instead

warning: use of deprecated function `criterion::black_box`: use `std::hint::black_box()` instead
  --> benches/benchmarks/burntsushi_torture_regex.rs:38:48
   |
38 |         b.iter(|| burntsushi_pathological_case(black_box(n_alts), black_box(n_reps)))
   |                                                ^^^^^^^^^

Check warning on line 13 in benches/benchmarks/burntsushi_torture_regex.rs

github-actions / clippy

use of deprecated function `criterion::black_box`: use `std::hint::black_box()` instead

warning: use of deprecated function `criterion::black_box`: use `std::hint::black_box()` instead
  --> benches/benchmarks/burntsushi_torture_regex.rs:13:17
   |
13 | use criterion::{black_box, criterion_group, criterion_main, Criterion};
   |                 ^^^^^^^^^
   |
   = note: `#[warn(deprecated)]` on by default

Check warning on line 69 in src/lsp/client.rs

github-actions / clippy

this can be `std::io::Error::other(_)`

warning: this can be `std::io::Error::other(_)`
  --> src/lsp/client.rs:69:32
   |
69 |                     return Err(io::Error::new(io::ErrorKind::Other, e));
   |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
note: the lint level is defined here
  --> src/lib.rs:5:5
   |
5  |     clippy::style,
   |     ^^^^^^^^^^^^^
   = note: `#[warn(clippy::io_other_error)]` implied by `#[warn(clippy::style)]`
help: use `std::io::Error::other`
   |
69 -                     return Err(io::Error::new(io::ErrorKind::Other, e));
69 +                     return Err(io::Error::other(e));
   |

Check warning on line 22 in crates/ninep/src/sync/mod.rs

github-actions / clippy

this can be `std::io::Error::other(_)`

warning: this can be `std::io::Error::other(_)`
  --> crates/ninep/src/sync/mod.rs:22:26
   |
22 |             .map_err(|e| io::Error::new(io::ErrorKind::Other, e.to_string()))?;
   |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
help: use `std::io::Error::other`
   |
22 -             .map_err(|e| io::Error::new(io::ErrorKind::Other, e.to_string()))?;
22 +             .map_err(|e| io::Error::other(e.to_string()))?;
   |

Check warning on line 39 in crates/ninep/src/sansio/client.rs

github-actions / clippy

this can be `std::io::Error::other(_)`

warning: this can be `std::io::Error::other(_)`
  --> crates/ninep/src/sansio/client.rs:39:9
   |
39 |     Err(io::Error::new(io::ErrorKind::Other, e))
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
note: the lint level is defined here
  --> crates/ninep/src/lib.rs:5:5
   |
5  |     clippy::style,
   |     ^^^^^^^^^^^^^
   = note: `#[warn(clippy::io_other_error)]` implied by `#[warn(clippy::style)]`
help: use `std::io::Error::other`
   |
39 -     Err(io::Error::new(io::ErrorKind::Other, e))
39 +     Err(io::Error::other(e))
   |

View more details on GitHub Actions