Verify that user who assigned us is allowed to merge - #382
Open
hashworks wants to merge 2 commits into
Open
Conversation
This ensures that the user who assigned marge bot to a merge request is a member of the project and has the required access level for the target branch.
|
@hashworks You might check the https://gitlab.com/marge-org/marge-bot project out. As this project seems to be un-maintained. |
Author
|
@JohnVillalovos Ah, thanks. Since it seems to be missing a Permission-Check as well I'll post the MR there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that the user who assigned marge bot to a merge request is a member of the project and has the required access level for the target branch.
Otherwise, any user that can assign merge requests could merge into branches marge-bot has access to.