Skip to content

Use target branch name in batch merge to allow multiple instances - #271

Open
valentindavid wants to merge 1 commit into
smarkets:masterfrom
valentindavid:multi-target-batch
Open

Use target branch name in batch merge to allow multiple instances#271
valentindavid wants to merge 1 commit into
smarkets:masterfrom
valentindavid:multi-target-batch

Conversation

@valentindavid

Copy link
Copy Markdown

A project can use multiple instances of marge bots assigned to
different target branches. This allows dealing with different
release branches in parallel.

However batches could not be used on multiple instances because
they conflicted on the name of the branch created for the batch.
By naming this branch after the target branch, then multiple
batch branches can exist.

Fixes #267

A project can use multiple instances of marge bots assigned to
different target branches. This allows dealing with different
release branches in parallel.

However batches could not be used on multiple instances because
they conflicted on the name of the branch created for the batch.
By naming this branch after the target branch, then multiple
batch branches can exist.
@sg70

sg70 commented Feb 14, 2021

Copy link
Copy Markdown
Contributor

@tclh123 Is there a chance that this PR gets merged?
@valentindavid can you update your PR?

@tclh123

tclh123 commented Feb 16, 2021

Copy link
Copy Markdown
Contributor

@sg70 Yeah, I think this is good. Not sure if we want it to be configurable?

@qqshfox

qqshfox commented Apr 30, 2021

Copy link
Copy Markdown
Contributor

@valentindavid Thanks for the contribution. Changing the branch name for branch will be a breaking change. Would you please add a configuration that is disabled by default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot run multiple batch-enabled instances on separate target branches

4 participants