Skip to content

Improve batching: allow batch MRs use merge commits - #264

Merged
bostik merged 14 commits into
smarkets:masterfrom
tclh123:batch2
Oct 6, 2020
Merged

Improve batching: allow batch MRs use merge commits#264
bostik merged 14 commits into
smarkets:masterfrom
tclh123:batch2

Conversation

@tclh123

@tclh123 tclh123 commented Jul 28, 2020

Copy link
Copy Markdown
Contributor

Previously, we applies the commits in individual MRs to the batch MR linearly, so the commits will be rewritten and the commit sha will not be the same one passed CI, which is not good.

To make the commits be exactly the same in the individual MRs and the batch MR, I added an option to allow using merge commits in batch MRs. It acts as a helper commit in the temp branch (the batch branch) which won't affect the final merge method (we usually use the fast forwarding merge).
Besides, updating (rebase master and apply trailers) each MR before we create the batch MR to avoid rewrite commits after.

  • Add --use-merge-commit-batches option: Use merge commit when creating batches, so that the commits in the batch MR will be the same with in individual MRs.
  • Add --skip-ci-batches option: Skip CI when updating individual MRs when using batches. Since we have tested the batch MR, no need to run CI on individual MRs any more after we rewrite the commits.

Fixes #164 #252

Comment thread marge/batch_job.py

@bostik bostik left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could fold this commit to its parent. It only adds noise to the commit history.

Comment thread marge/app.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When using the --batch feature the commit hashes that end up on master are not the same hashes that tests were run on

2 participants