Repository navigation
PS-22014: Modernize OAuth2 with async/await and strict concurrency - #47
Draft
DominikPalo wants to merge 12 commits into
Draft
DominikPalo wants to merge 12 commits into
DominikPalo wants to merge 12 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernizes the OAuth2 package around Swift concurrency. This is an intentional, breaking API redesign: the legacy callback/subclass architecture and non-SPM project definitions are removed in favor of a Swift Package Manager-only library centered on an async/await
OAuth2Clientactor.Implements the first phase of PS-22014: replace the closure-based API, use modern Swift language features, improve maintainability, and establish comprehensive deterministic unit coverage.
What changed
OAuth2Clientactor and explicitSendableconfiguration, credential, token, response, and error models.OAuth2AuthorizationPresenteris isolated toMainActor, while token and network work remain safe for background callers.OAuth2ResourceClientfor concurrent protected-resource requests. It performs generation-aware 401 recovery, coalesces recovery work, and makes at most one retry—never triggering interactive authorization itself.SwiftKeychainwith a queue-isolated Security-framework credential store; removed the semaphore and logging dependencies.Breaking changes
OAuth2ClientandOAuth2ResourceClient.Migration guidance and examples are available in
Docs/ASYNC_AWAIT_MIGRATION.mdand the updated README.Scope notes
This PR does not add DPoP support or a replacement logging API; those remain follow-up modernization work from the Jira epic.
Validation
swift test— 26 tests passed locally.