-
Notifications
You must be signed in to change notification settings - Fork 674
feat(web-api): add workflows.featured.{add|list|remove|set} methods #2303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
643e1c5
feat(web-api): add workflows.featured.{add|list|remove|set} methods
zimeg 5ade4c4
fix: avoid warnings of deprecated methods for new workflow methods
zimeg 3885a76
chore: merge w main
zimeg efbd881
test: confirm unexpected arguments cause type errors
zimeg c8138ca
style: run the linter before making a commit
zimeg 96ba3b5
chore: merge w main
zimeg 3b967a8
chore: merge w main
zimeg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
packages/web-api/src/types/response/WorkflowsFeaturedAddResponse.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| import type { WebAPICallResult } from '../../WebClient'; | ||
|
|
||
| export type WorkflowsFeaturedAddResponse = WebAPICallResult & {}; |
11 changes: 11 additions & 0 deletions
11
packages/web-api/src/types/response/WorkflowsFeaturedListResponse.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import type { WebAPICallResult } from '../../WebClient'; | ||
|
|
||
| export type WorkflowsFeaturedListResponse = WebAPICallResult & { | ||
| featured_workflows: { | ||
| channel_id: string; | ||
| triggers: { | ||
| id: string; | ||
| title: string; | ||
| }[]; | ||
| }[]; | ||
| }; |
3 changes: 3 additions & 0 deletions
3
packages/web-api/src/types/response/WorkflowsFeaturedRemoveResponse.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| import type { WebAPICallResult } from '../../WebClient'; | ||
|
|
||
| export type WorkflowsFeaturedRemoveResponse = WebAPICallResult & {}; |
3 changes: 3 additions & 0 deletions
3
packages/web-api/src/types/response/WorkflowsFeaturedSetResponse.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| import type { WebAPICallResult } from '../../WebClient'; | ||
|
|
||
| export type WorkflowsFeaturedSetResponse = WebAPICallResult & {}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
116 changes: 116 additions & 0 deletions
116
packages/web-api/test/types/methods/workflows.test-d.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| import { expectAssignable, expectError } from 'tsd'; | ||
|
|
||
| import { WebClient } from '../../../src/WebClient'; | ||
|
|
||
| const web = new WebClient('TOKEN'); | ||
|
|
||
| // workflows.featured.add | ||
| // -- sad path | ||
| expectError(web.workflows.featured.add()); // lacking argument | ||
| expectError(web.workflows.featured.add({})); // empty argument | ||
| expectError( | ||
| web.workflows.featured.add({ | ||
| channel_id: 'C1234', // missing trigger_ids | ||
| }), | ||
| ); | ||
| expectError( | ||
| web.workflows.featured.add({ | ||
| trigger_ids: [], // missing channel_id | ||
| }), | ||
| ); | ||
| expectError( | ||
| web.workflows.featured.add({ | ||
| channel_id: 'C1234', | ||
| trigger_ids: 'Ft1234', // not an array | ||
| }), | ||
| ); | ||
| // -- happy path | ||
| expectAssignable<Parameters<typeof web.workflows.featured.add>>([ | ||
| { | ||
| channel_id: 'C1234', | ||
| trigger_ids: [], | ||
| }, | ||
| ]); | ||
| expectAssignable<Parameters<typeof web.workflows.featured.add>>([ | ||
| { | ||
| channel_id: 'C1234', | ||
| trigger_ids: ['Ft1234', 'Ft0001'], | ||
| }, | ||
| ]); | ||
|
|
||
| // workflows.featured.list | ||
| // -- sad path | ||
| expectError(web.workflows.featured.list()); // lacking argument | ||
| expectError(web.workflows.featured.list({})); // empty argument | ||
| expectError( | ||
| web.workflows.featured.list({ | ||
| channel_ids: 'C1234', // not an array | ||
| }), | ||
| ); | ||
| // -- happy path | ||
| expectAssignable<Parameters<typeof web.workflows.featured.list>>([ | ||
| { | ||
| channel_ids: [], | ||
| }, | ||
| ]); | ||
| expectAssignable<Parameters<typeof web.workflows.featured.list>>([ | ||
| { | ||
| channel_ids: ['C1234', 'C0001'], | ||
| }, | ||
| ]); | ||
|
|
||
| // workflows.featured.remove | ||
| // -- sad path | ||
| expectError(web.workflows.featured.remove()); // lacking argument | ||
| expectError(web.workflows.featured.remove({})); // empty argument | ||
| expectError( | ||
| web.workflows.featured.remove({ | ||
| channel_id: 'C1234', // missing trigger_ids | ||
| }), | ||
| ); | ||
| expectError( | ||
| web.workflows.featured.remove({ | ||
| trigger_ids: [], // missing channel_id | ||
| }), | ||
| ); | ||
| // -- happy path | ||
| expectAssignable<Parameters<typeof web.workflows.featured.remove>>([ | ||
| { | ||
| channel_id: 'C1234', | ||
| trigger_ids: [], | ||
| }, | ||
| ]); | ||
| expectAssignable<Parameters<typeof web.workflows.featured.remove>>([ | ||
| { | ||
| channel_id: 'C1234', | ||
| trigger_ids: ['Ft1234', 'Ft0001'], | ||
| }, | ||
| ]); | ||
|
|
||
| // workflows.featured.set | ||
| // -- sad path | ||
| expectError(web.workflows.featured.set()); // lacking argument | ||
| expectError(web.workflows.featured.set({})); // empty argument | ||
| expectError( | ||
| web.workflows.featured.set({ | ||
| channel_id: 'C1234', // missing trigger_ids | ||
| }), | ||
| ); | ||
| expectError( | ||
| web.workflows.featured.set({ | ||
| trigger_ids: [], // missing channel_id | ||
| }), | ||
| ); | ||
| // -- happy path | ||
| expectAssignable<Parameters<typeof web.workflows.featured.set>>([ | ||
| { | ||
| channel_id: 'C1234', | ||
| trigger_ids: [], | ||
| }, | ||
| ]); | ||
| expectAssignable<Parameters<typeof web.workflows.featured.set>>([ | ||
| { | ||
| channel_id: 'C1234', | ||
| trigger_ids: ['Ft1234', 'Ft0001'], | ||
| }, | ||
| ]); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📣 Somewhat related change to avoid warnings of these new methods being deprecated:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice; did
['workflows.']trigger this warning for any method that started withworkflows?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vegeris It did and I was super confused at first, thinking that was sent from the API!
I forget when this logic was first added, but narrowing the deprecations down to exact methods seems useful going forward since this might've been warning for adjacent methods 😳