-
Notifications
You must be signed in to change notification settings - Fork 674
feat: add support to @slack/web-api for work objects #2231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 26 commits
c8c3482
a3f8922
dde54aa
5813ae6
6892aef
9e8988b
c3cef1f
67cc8b6
da092d5
d4231dd
d889e07
e6bd2ac
c54c9b3
24ecda6
ba79b81
02e5360
b983ca5
8201026
e4284e3
bb49dd5
480cb1f
c4992f6
d2a9d93
c4cb46c
ec18401
6f56034
eeef76d
a44d4b3
1d4325b
019cfd3
fae7b17
a2eaa71
26e3aa5
4eaeed8
6d2ebc4
a9c5d4e
c0cc1f6
d974164
9b5ecf1
5c174bd
de9e02a
3ae9720
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| export interface EntityDetailsRequestedEvent { | ||
| type: 'entity_details_requested'; | ||
| user: string; | ||
| trigger_id: string; | ||
| link: { | ||
| url: string; | ||
| domain: string; | ||
| }; | ||
| entity_url: string; | ||
| app_unfurl_url?: string; | ||
| user_locale: string; | ||
| event_ts: string; | ||
| external_ref?: { | ||
| id: string; | ||
| type?: string; | ||
| }; | ||
| message_ts?: string; | ||
| thread_ts?: string; | ||
| channel?: string; | ||
| } |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||||
| { | ||||||
| "name": "@slack/web-api", | ||||||
| "version": "7.11.0", | ||||||
| "version": "7.11.0-featWorkObjectsBeta.2", | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
🪓 todo: We ought revert this before merge! |
||||||
| "description": "Official library for using the Slack Platform's Web API", | ||||||
| "author": "Slack Technologies, LLC", | ||||||
| "license": "MIT", | ||||||
|
|
@@ -49,7 +49,7 @@ | |||||
| }, | ||||||
| "dependencies": { | ||||||
| "@slack/logger": "^4.0.0", | ||||||
| "@slack/types": "^2.17.0", | ||||||
| "@slack/types": "2.17.0-featWorkObjectsBeta.2", | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
🔮 todo(follow-up): This I think is fine to merge as a prerelease but we should release
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, good point 😅 So if I understand correctly, we would be okay to merge this PR with the web-api package pointing to the types package pre-release, and as a fast follow we would release a minor version of the types package, and then the web-api with that dependency updated (after the work objects Houston toggle is full released) |
||||||
| "@types/node": ">=18.0.0", | ||||||
| "@types/retry": "0.12.0", | ||||||
| "axios": "^1.11.0", | ||||||
|
|
||||||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪓 todo: Before merging let's revert this!😳 edit: Oop perhaps not for this package!