Skip to content

fix(typescript): accept empty list of suggested prompts for the assistant class #2650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zimeg merged 1 commit into from
Sep 9, 2025
Merged

fix(typescript): accept empty list of suggested prompts for the assistant class #2650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Assistant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ type SetSuggestedPromptsFn = (

interface SetSuggestedPromptsArguments {
/** @description Prompt suggestions that appear when opening assistant thread. */
prompts: [AssistantPrompt, ...AssistantPrompt[]];
prompts: AssistantPrompt[];
/** @description Title for the prompts. */
title?: string;
}
Expand Down
8 changes: 7 additions & 1 deletion test/types/assistant.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import type { AssistantThreadsSetSuggestedPromptsResponse } from '@slack/web-api';
import { expectError, expectType } from 'tsd';
import { type AllAssistantMiddlewareArgs, Assistant } from '../../src/Assistant';
import type { AssistantThreadContext } from '../../src/AssistantThreadContextStore';
Expand Down Expand Up @@ -33,8 +34,13 @@ expectType<Assistant>(
// threadStarted tests
new Assistant({
userMessage: asyncNoop,
threadStarted: async ({ saveThreadContext }) => {
threadStarted: async ({ saveThreadContext, setSuggestedPrompts }) => {
expectType<void>(await saveThreadContext());
expectType<AssistantThreadsSetSuggestedPromptsResponse>(
await setSuggestedPrompts({
prompts: [],
}),
);
return Promise.resolve();
},
});
Expand Down