Skip to content

Add entity_details_requested event support#28

Merged
StephenTangCook merged 1 commit intoslack-edge:mainfrom
kang8:add-entity-details-requested-event
Mar 25, 2026
Merged

Add entity_details_requested event support#28
StephenTangCook merged 1 commit intoslack-edge:mainfrom
kang8:add-entity-details-requested-event

Conversation

@kang8
Copy link
Copy Markdown
Contributor

@kang8 kang8 commented Feb 11, 2026

Summary

  • Add entity_details_requested to the AnyManifestEvent union type for work objects support
  • Mirror the change in the Deno-compatible copy (src_deno/manifest/events.ts)

Context

Slack added the entity_details_requested event for work objects. The official node-slack-sdk added this in PR slackapi/node-slack-sdk#2412. This PR adds the corresponding event string to this library's manifest event types.

Test plan

  • TypeScript compilation passes (tsc --noEmit)
  • Formatting check passes (biome format)

@kang8
Copy link
Copy Markdown
Contributor Author

kang8 commented Feb 11, 2026

P.S. The script comment at the top of the events files is outdated:

// https://api.slack.com/events?filter=Events
// var events = [].slice.call(document.getElementsByClassName('apiReferenceFilterableList__listItemLink')).map(e => '"' + e.innerText + '"').join(' | '); console.log("export type AnyManifestEvent = Exclude<" + events + ", 'app_rate_limited'>;");
export type AnyManifestEvent = Exclude<

  • The URL https://api.slack.com/events?filter=Events now redirects to https://docs.slack.dev/reference/events/
  • The new page no longer uses the apiReferenceFilterableList__listItemLink class, so the browser console snippet can no longer be used to generate the events list

@kang8 kang8 changed the title Add entity_details_requested event support Add entity_details_requested event support Feb 11, 2026
kang8 added a commit to kang8/slack-edge that referenced this pull request Feb 11, 2026
Remove entity_details_requested from SupportedEventType override
since the event type string is being added to AnyEventType upstream
in slack-edge/slack-web-api-client#28.
@StephenTangCook StephenTangCook merged commit 4343cff into slack-edge:main Mar 25, 2026
@StephenTangCook StephenTangCook mentioned this pull request Mar 25, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants