Flatpak Build#566
Draft
TheRealYasri wants to merge 7 commits intoskylersaleh:devfrom
Draft
Conversation
Open
The path to the sandboxed saves, bios, and cheats, were not being used if skyemu was launched from the rom instead of the .desktop file in all cases with default set paths. Made sure skyemu was launched from the home dir not the path of the rom.
Changed default paths to ./saves/ ./bios/ ./cheats/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be almost ready, it builds fine. And i have given it a test drive and it seems to work ok.
Needs some pics of the app host publicly to pull from for the flathub store to use. The image in the README.md is not link-able, it breaks. I think it needs to be upload differently so its not hosted at private-user-images.githubusercontent.com
Also I need to add some more info to the store description section. with how to add more white listed directories if people need them. currently I added the paths for extra drives ( /mnt /media /run/media )as read only and nothing else.
it should be setup to create the bios, saves, cheats folders in the sandbox with them set as the default path.
I think that is everything.