Skip to content

The balloon renders in a PopupWindow for the compatibilities#967

Merged
skydoves merged 1 commit intomainfrom
fix/size-compatibility
Apr 16, 2026
Merged

The balloon renders in a PopupWindow for the compatibilities#967
skydoves merged 1 commit intomainfrom
fix/size-compatibility

Conversation

@skydoves
Copy link
Copy Markdown
Owner

@skydoves skydoves commented Apr 16, 2026

The balloon renders in a PopupWindow for the compatibilities (#943, #952)

Summary by CodeRabbit

  • Bug Fixes

    • Improved balloon content measurement to correctly adapt to screen dimensions, ensuring consistent sizing across different device widths and configurations.
  • Chores

    • Updated version control settings to exclude generated build artifacts.

@skydoves skydoves self-assigned this Apr 16, 2026
@skydoves skydoves merged commit 62c137b into main Apr 16, 2026
4 of 5 checks passed
@skydoves skydoves deleted the fix/size-compatibility branch April 16, 2026 06:15
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 16, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 66305265-bf10-40b5-9bef-0aac2552c2db

📥 Commits

Reviewing files that changed from the base of the PR and between 849f791 and 473a1fb.

📒 Files selected for processing (3)
  • .gitignore
  • balloon-compose/src/main/kotlin/com/skydoves/balloon/compose/Balloon.kt
  • balloon-compose/src/main/kotlin/com/skydoves/balloon/compose/BalloonModifier.kt

Walkthrough

This pull request adjusts balloon content measurement and layout logic in Compose. Changes to Balloon.kt and BalloonModifier.kt shift from deriving max width/height from parent layout constraints to using screen-width-based values unconditionally, simplifying constraint handling logic.

Changes

Cohort / File(s) Summary
Version Control
.gitignore
Added .hotswan/ directory to ignore list.
Balloon Measurement Logic
balloon-compose/src/main/kotlin/com/skydoves/balloon/compose/Balloon.kt, balloon-compose/src/main/kotlin/com/skydoves/balloon/compose/BalloonModifier.kt
Refactored max width/height computation to unconditionally use screen-width-based values instead of deriving from parent constraints. Removed conditional logic for unbounded width/height and Constraints.Infinity special-casing. maxContentWidth now uses screenWidth - horizontalPadding; maxHeight defaults to screenWidth * 2.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Possibly related PRs

Poem

🐰 The constraints did bind our balloons so tight,
But screenWidth now guides them to their height!
No more parent limits shall constrain our view,
The measurements dance with the screen's truest hue. 🎈

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/size-compatibility

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant