Skip to content

Set the min height size#966

Merged
skydoves merged 1 commit intomainfrom
fix/height-min
Apr 16, 2026
Merged

Set the min height size#966
skydoves merged 1 commit intomainfrom
fix/height-min

Conversation

@skydoves
Copy link
Copy Markdown
Owner

@skydoves skydoves commented Apr 16, 2026

Set the min height size (#963)

Summary by CodeRabbit

  • Bug Fixes
    • Fixed a layout measurement issue that could cause incorrect balloon component sizing under certain height configurations.

@skydoves skydoves self-assigned this Apr 16, 2026
@skydoves skydoves merged commit 849f791 into main Apr 16, 2026
4 of 5 checks passed
@skydoves skydoves deleted the fix/height-min branch April 16, 2026 05:59
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 16, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bbcef9af-1f61-4f49-a49c-b7c83e45130d

📥 Commits

Reviewing files that changed from the base of the PR and between 5457011 and ab41c95.

📒 Files selected for processing (1)
  • balloon-compose/src/main/kotlin/com/skydoves/balloon/compose/BalloonModifier.kt

Walkthrough

The change adds .coerceAtLeast(0) to clamp the computed effectiveMaxHeight to a non-negative value in the Modifier.balloon function's layout measure policy, preventing negative height constraints from propagating downstream.

Changes

Cohort / File(s) Summary
Height Constraint Clamping
balloon-compose/src/main/kotlin/com/skydoves/balloon/compose/BalloonModifier.kt
Clamps effectiveMaxHeight to non-negative value using .coerceAtLeast(0) to prevent negative height constraints in layout measurement.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Bouncing heights so high, so free,
But negative? No, that won't be!
Coerce at least to zero's light,
Now balloons measure just right!

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/height-min

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant