[ENH] Add online regressor support and River adapter#1068
Open
patelchaitany wants to merge 2 commits into
Open
[ENH] Add online regressor support and River adapter#1068patelchaitany wants to merge 2 commits into
patelchaitany wants to merge 2 commits into
Conversation
88ea31c to
732a597
Compare
6ca8dfc to
57f3208
Compare
Add River adapter package (utils, clone, RiverRegressor) and a coerce_to_skpro_regressor helper. Introduce BaseOnlineRegressor and capability:pred_int tag; update BaseProbaRegressor to check pred_int for probabilistic methods.
ed314f0 to
4424926
Compare
fkiraly
requested changes
Jun 14, 2026
fkiraly
left a comment
Collaborator
There was a problem hiding this comment.
Nice! Though I think there is somet duplication going on.
- I think the new base class,
BaseOnlineRegressor, can be merged intoBaseProbaRegressor, there is no substantial added functionality. - The new jackknife-plus regressor can be merged into the existing one (the non-MAPIE regressor), simply add the
updatelogic.
4424926 to
90cd8a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#1066
What does this implement/fix? Explain your changes.
This PR adds the foundation for online regression in skpro, including a new regressor_online scitype and BaseOnlineRegressor with capability:update and capability:pred_int. It introduces the capability:pred_int tag and gates probabilistic prediction methods on regressors that do not support them. It also adds RiverRegressor as a point-prediction adapter for River models, with deepcopy-based cloning and coerce_to_skpro_regressor() for wrapping raw River estimators.
Does your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
Any other comments?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skproroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
For new estimators
docs/source/api_reference/taskname.rst, follow the pattern.Examplessection.python_dependenciestag and ensureddependency isolation, see the estimator dependencies guide.