feat(be): accept student id for course registration - #3703
Open
suhyeon1ee wants to merge 1 commit into
Open
Conversation
수강 등록 요청 body에서 학번을 검증하고 서비스로 전달한다.\n변경된 API 계약에 맞춰 컨트롤러와 Bruno 테스트를 수정한다.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
학생이 강의 등록을 요청할 때 입력한 학번을 백엔드에서 전달받을 수 있도록 수강 등록 API를 수정합니다.
기존 API는 초대 코드만 전달받았기 때문에, 후속 수강생 명단 검증 로직에서 학생이 입력한 학번을 사용할 수 없었습니다. 이번 PR에서는 학번을
request body로 받아 검증한 뒤 서비스 계층까지 전달합니다.
이 PR은 전체 강의 등록 개선 Task의 하위 작업이며,
t2831-implement-course-register브랜치를 대상으로 합니다.Closes TAS-2848
Description
Additional context
Before submitting the PR, please make sure you do the following
fixes #123).