Conversation
…ough backhaul - Add GitSSHSigningKey to StartServicesDaemonOptions so daemon-based browser IDE sessions forward the SSH signing key for git commits - Pass context to SetupBackhaul so the backhaul process is terminated when the browser session ends instead of being orphaned - Restore portability comment on sleep command - Close log writer in SetupBackhaul
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 11 minutes and 21 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Summary
Fast follow from #719. Fixes two pre-existing issues surfaced during review:
GitSSHSigningKey not propagated in daemon path: Daemon-based browser IDE sessions (e.g. DevPod Pro) silently dropped the SSH signing key, so git commit signing didn't work. The SSH tunnel path already handled this correctly. Adds
GitSSHSigningKeytoStartServicesDaemonOptionsand propagates it frommakeDaemonStartFunc.SetupBackhaul not context-aware: The backhaul SSH process (
devpod ssh --command "while true; do sleep 6000000; done") usedexec.Commandinstead ofexec.CommandContext, so it was orphaned when the browser session ended. Now uses the caller's context for proper cleanup.Also restores a portability comment explaining why
while true; do sleep 6000000; doneis used instead ofsleep infinity(not available on all systems), and adds a deferredwriter.Close()inSetupBackhaul.