Skip to content

fix: propagate git SSH signing key in daemon path and context in backhaul#722

Merged
skevetter merged 1 commit intomainfrom
fix/backhaul-context-and-daemon-signing-key
Apr 12, 2026
Merged

fix: propagate git SSH signing key in daemon path and context in backhaul#722
skevetter merged 1 commit intomainfrom
fix/backhaul-context-and-daemon-signing-key

Conversation

@skevetter
Copy link
Copy Markdown
Owner

@skevetter skevetter commented Apr 12, 2026

Summary

Fast follow from #719. Fixes two pre-existing issues surfaced during review:

  • GitSSHSigningKey not propagated in daemon path: Daemon-based browser IDE sessions (e.g. DevPod Pro) silently dropped the SSH signing key, so git commit signing didn't work. The SSH tunnel path already handled this correctly. Adds GitSSHSigningKey to StartServicesDaemonOptions and propagates it from makeDaemonStartFunc.

  • SetupBackhaul not context-aware: The backhaul SSH process (devpod ssh --command "while true; do sleep 6000000; done") used exec.Command instead of exec.CommandContext, so it was orphaned when the browser session ended. Now uses the caller's context for proper cleanup.

Also restores a portability comment explaining why while true; do sleep 6000000; done is used instead of sleep infinity (not available on all systems), and adds a deferred writer.Close() in SetupBackhaul.

…ough backhaul

- Add GitSSHSigningKey to StartServicesDaemonOptions so daemon-based
  browser IDE sessions forward the SSH signing key for git commits
- Pass context to SetupBackhaul so the backhaul process is terminated
  when the browser session ends instead of being orphaned
- Restore portability comment on sleep command
- Close log writer in SetupBackhaul
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 12, 2026

Warning

Rate limit exceeded

@skevetter has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 21 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 11 minutes and 21 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: be38e9da-f88c-4034-8692-3bb181b7f3db

📥 Commits

Reviewing files that changed from the base of the PR and between b5d20ba and 105a084.

📒 Files selected for processing (3)
  • pkg/client/clientimplementation/services.go
  • pkg/ide/opener/opener.go
  • pkg/tunnel/browser.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/backhaul-context-and-daemon-signing-key

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skevetter
Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 12, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@skevetter skevetter merged commit d543be9 into main Apr 12, 2026
41 checks passed
@skevetter skevetter deleted the fix/backhaul-context-and-daemon-signing-key branch April 12, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant