Skip to content

Update thin version #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sj26 merged 1 commit into from
Jan 29, 2023
Merged

Update thin version #530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mailcatcher.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Gem::Specification.new do |s|
s.add_dependency "rack", "~> 1.5"
s.add_dependency "sinatra", "~> 1.2"
s.add_dependency "sqlite3", "~> 1.3"
s.add_dependency "thin", "~> 1.5.0"
s.add_dependency "thin", "~> 1.8"

@tagliala tagliala Jan 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just relax the dependency on the minor version number to preserve legacy installations (in case someone can't update thin but wants to update mailcatcher)

Suggested change
s.add_dependency "thin", "~> 1.8"
s.add_dependency "thin", "~> 1.5"

It also important to mention that this has been done on purpose in 4d7429c, so probably 1.6.0 should be excluded and newer thin releases should be tested


s.add_development_dependency "capybara"
s.add_development_dependency "capybara-screenshot"
Expand Down