-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: resolve Claude auth status via claude auth status instead of a credentials file
#1035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zscgeek
wants to merge
1
commit into
siteboon:main
Choose a base branch
from
zscgeek:fix/claude-auth-keychain-status
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🔴 Critical | ⚡ Quick win
Avoid blocking the event loop and handle execution errors correctly.
Using synchronous
spawn.syncinside anasyncfunction blocks the Node.js main thread for up to 10 seconds (the configured timeout). In a server environment, this stalls all concurrent requests and degrades availability.Additionally,
spawn.syncdoes not throw an exception when it fails to start the process (e.g., missing executable) or when it times out; it returns an error inresult.error. The currenttry/catchblock will not catch these failures, causing the code to swallow the error and fall through to reporting a misleading "missing credentials" error due to an emptystdout.Consider replacing
spawn.syncwith an asynchronous alternative (such aschild_process.execFilewrapped inutil.promisify), which correctly throws on spawn failures, timeouts, and non-zero exit codes without blocking the event loop.⚡ Proposed fix using promisified `execFile`
Assuming you have access to a promisified
execFile(e.g.,const execFileAsync = util.promisify(require('child_process').execFile)):🤖 Prompt for AI Agents