-
Notifications
You must be signed in to change notification settings - Fork 6
refactor(theme): replace brand-color ThemeProvider with light/dark mode toggle #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
ca2b5da
8f07bac
cbc0c39
c6fb5f3
243fcb9
6ef1e64
c9ebc40
83f6540
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| --- | ||
| "@sipe-team/theme": major | ||
| "@sipe-team/tokens": minor | ||
| --- | ||
|
|
||
| Replace brand-color ThemeProvider with light/dark mode toggle and align design tokens with SSOT. | ||
|
|
||
| - `ThemeProvider` now applies themes via `data-theme` attribute instead of `assignInlineVars` | ||
| - `theme` prop changed from brand-color objects to `'light' | 'dark'` string union | ||
| - `ColorTheme` type is now exported from `@sipe-team/tokens` | ||
| - VE contract structure for `color`, `spacing`, and `radius` reorganized into semantic token hierarchy | ||
| - Token values in `themes.css.ts` now reference Style Dictionary CSS variables instead of hardcoded JS constants | ||
| - Removed `@vanilla-extract/dynamic` dependency from `@sipe-team/theme` | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,12 +12,13 @@ | |
| "Bash(ls*)", | ||
| "Edit", | ||
| "Write", | ||
| "Read" | ||
| "Read", | ||
| "Read(./packages/tokens/dist/*)" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이거 dist/** 로 해야하지 않을까요...? |
||
| ], | ||
| "ask": ["Bash(git push*)", "Bash(git commit*)", "Bash(git reset*)", "Bash(rm *)"], | ||
| "deny": [ | ||
| "Read(**/dist/**)", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. deny 가 allow 보다 우선되므로, |
||
| "Read(./node_modules/)", | ||
| "Read(./dist/)", | ||
| "Read(./storybook-static/)", | ||
| "Read(./www/build/)", | ||
| "Read(./www/.docusaurus/)", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
실제 export 되는건
ThemeMode아닌가요??