fix: prevent editor:pageCreating from firing twice in Vim mode#2017
Open
iblamesurya wants to merge 1 commit into
Open
fix: prevent editor:pageCreating from firing twice in Vim mode#2017iblamesurya wants to merge 1 commit into
iblamesurya wants to merge 1 commit into
Conversation
When toggling Vim mode, setUiOption calls reloadEditor() which calls loadPage(). For virtual/new pages, loadPage() hits a notFoundError in readPage(), causing editor:pageCreating to fire a second time unexpectedly (issue silverbulletmd#2012). Fix: rebuild the editor state directly using the text already in memory (sliceDoc + createEditorState) instead of going through the full loadPage() path, which avoids re-dispatching editor:pageCreating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When toggling Vim mode, setUiOption calls reloadEditor() which calls loadPage(). For virtual/new pages, loadPage() hits a notFoundError in readPage(), causing editor:pageCreating to fire a second time unexpectedly (issue #2012).
Fix: rebuild the editor state directly using the text already in memory (sliceDoc + createEditorState) instead of going through the full loadPage() path, which avoids re-dispatching editor:pageCreating.