Expose CorrectHomographNumbers publicly on ILexEntry#375
Conversation
jasonleenaylor
left a comment
There was a problem hiding this comment.
From an API standpoint I don't like adding a method on LexEntry which modifies data in other LexEntries. This should be exposed, but I don't think it belongs here.
@jasonleenaylor reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved.
|
@jasonleenaylor You're right. I moved it. API-wise it would be arguably better to make the signature of my new method more similar to |
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: 4 of 5 files reviewed, all discussions resolved.
Adds
ILexEntry.CorrectHomographNumbers()which wraps the existingLexDb.CorrectHomographNumbersalgorithm.FieldWorks Lite writes
HomographNumberdirectly and needs a way to trigger a "cleanup" of a potentially broken homograph sequence.This change is