-
Notifications
You must be signed in to change notification settings - Fork 140
fix(core/content-header): Fix responsive content-header behavior #2702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dmytro-halimov
wants to merge
20
commits into
main
Choose a base branch
from
fix/content-header-responsive-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
7e69f2e
fix(core/content-header): Fix responsive content-header behavior
dmytro-halimov 6da019f
fix(core/content-header): Update snapshots
dmytro-halimov f5f7a05
fix(core/content-header): Apply CSS token instea of a hardcoded value
dmytro-halimov f0f363b
test(core/content-header): restore and align test layouts
nuke-ellington ddc4e7a
Merge branch 'main' into fix/content-header-responsive-fix
nuke-ellington 6239554
refactor(core/content-header): rename property value
nuke-ellington 6984ca0
docs(core/content-header): rename to match property name
nuke-ellington fb3f42f
docs(core/content-header): udpate example text and add story
nuke-ellington 80741de
refactor(core-content-header): Improvements after review
dmytro-halimov ae28d01
Merge branch 'main' into fix/content-header-responsive-fix
dmytro-halimov 7da3680
chore(core/content-header): Adjust changes for V6
dmytro-halimov 37da7cb
docs(core/content-header): restore basic example text
dmytro-halimov 28205fc
test(content-header): align accessibility snapshot with basic example
dmytro-halimov 501e135
Merge branch 'main' into fix/content-header-responsive-fix
dmytro-halimov b6b4a25
refactor(core/content-header): Improvements after review
dmytro-halimov a34ecd0
Merge branch 'main' into fix/content-header-responsive-fix
dmytro-halimov 7ff6d27
chore(core/content-header): Update build
dmytro-halimov c02a692
docs(core): fix lint issues in V5 migration guide
dmytro-halimov 94e7b58
test(core/content-header): use safe bounding box checks
dmytro-halimov 9abf6f0
Merge branch 'main' into fix/content-header-responsive-fix
alexkaduk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| '@siemens/ix': minor | ||
| '@siemens/ix-angular': minor | ||
| '@siemens/ix-react': minor | ||
| '@siemens/ix-vue': minor | ||
| --- | ||
|
|
||
| Add responsive wrapping for `ix-content-header` titles and subtitles and a `textOverflow="ellipsis"` option for compact single-line ellipsis behavior with native tooltips for both values. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
packages/angular-standalone-test-app/src/preview-examples/content-header-truncate.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| <!-- | ||
| SPDX-FileCopyrightText: 2026 Siemens AG | ||
|
|
||
| SPDX-License-Identifier: MIT | ||
|
|
||
| This source code is licensed under the MIT license found in the | ||
| LICENSE file in the root directory of this source tree. | ||
| --> | ||
|
|
||
| <ix-content-header | ||
| hasBackButton | ||
| headerTitle="Content title that remains compact when horizontal space is limited" | ||
| headerSubtitle="Supporting context is available from the native tooltip" | ||
| textOverflow="ellipsis" | ||
| > | ||
| <ix-button variant="tertiary">Button1</ix-button> | ||
| <ix-button variant="tertiary">Button2</ix-button> | ||
| <ix-button variant="tertiary">Button3</ix-button> | ||
| </ix-content-header> |
18 changes: 18 additions & 0 deletions
18
packages/angular-standalone-test-app/src/preview-examples/content-header-truncate.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| /* | ||
| * SPDX-FileCopyrightText: 2026 Siemens AG | ||
| * | ||
| * SPDX-License-Identifier: MIT | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| import { Component } from '@angular/core'; | ||
| import { IxButton, IxContentHeader } from '@siemens/ix-angular/standalone'; | ||
|
|
||
| @Component({ | ||
| selector: 'app-example', | ||
| imports: [IxContentHeader, IxButton], | ||
| templateUrl: './content-header-truncate.html', | ||
| }) | ||
| export default class ContentHeaderTruncate {} |
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I know I made that change but we should go back to "Content title" and "Subtitle" for the basic examples. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
packages/angular-test-app/src/preview-examples/content-header-truncate.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| <!-- | ||
| SPDX-FileCopyrightText: 2026 Siemens AG | ||
|
|
||
| SPDX-License-Identifier: MIT | ||
|
|
||
| This source code is licensed under the MIT license found in the | ||
| LICENSE file in the root directory of this source tree. | ||
| --> | ||
|
|
||
| <ix-content-header | ||
| hasBackButton | ||
| headerTitle="Content title that remains compact when horizontal space is limited" | ||
| headerSubtitle="Supporting context is available from the native tooltip" | ||
| textOverflow="ellipsis" | ||
| > | ||
| <ix-button variant="tertiary">Button1</ix-button> | ||
| <ix-button variant="tertiary">Button2</ix-button> | ||
| <ix-button variant="tertiary">Button3</ix-button> | ||
| </ix-content-header> |
17 changes: 17 additions & 0 deletions
17
packages/angular-test-app/src/preview-examples/content-header-truncate.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| /* | ||
| * SPDX-FileCopyrightText: 2026 Siemens AG | ||
| * | ||
| * SPDX-License-Identifier: MIT | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| import { Component } from '@angular/core'; | ||
|
|
||
| @Component({ | ||
| standalone: false, | ||
| selector: 'app-example', | ||
| templateUrl: './content-header-truncate.html', | ||
| }) | ||
| export default class ContentHeaderTruncate {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have come to the conclusion, that this can be considered a visual breaking change.
Therefore we should push this to V6. Please adapt PR accordingly.