fix(tree-view): align items with and without folder state toggle - #2618
Open
chintankavathia wants to merge 1 commit into
Open
fix(tree-view): align items with and without folder state toggle#2618chintankavathia wants to merge 1 commit into
chintankavathia wants to merge 1 commit into
Conversation
The start toggle slot was hardcoded to 24px while the toggle icon renders at `--si-tree-view-icon-size` (1.25rem). Leaf items were therefore indented 4px more than their foldable siblings on the same level. Reserve the actual icon size instead, so the slot also scales with the root font size and a custom icon size. Closes #2550
chintankavathia
marked this pull request as ready for review
August 25, 2026 12:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The start toggle slot was hardcoded to 24px while the toggle icon renders at
--si-tree-view-icon-size(1.25rem). Leaf items were therefore indented 4px more than their foldable siblings on the same level. Reserve the actual icon size instead, so the slot also scales with the root font size and a custom icon size.Closes #2550
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: