refactor(accordion): use @angular/aria primitives - #2602
Open
chintankavathia wants to merge 1 commit into
Open
Conversation
chintankavathia
marked this pull request as ready for review
August 24, 2026 08:39
spike-rabbit
left a comment
spike-rabbit
left a comment
Member
There was a problem hiding this comment.
I don't think we add a real value here by using angular/aria. It is even more code than before and it did not reduce any complexity.
Member
Author
It does remove all the manual aria bindings + manual keydown event + manual disable checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2570
Related to #1070
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: