feat(chat-message): remove contentFormatter in favor of content projection - #2584
feat(chat-message): remove contentFormatter in favor of content projection#2584dr-itz wants to merge 6 commits into
Conversation
dr-itz
changed the title
4ea2456 to
e210c14
Compare
|
Makes sense with the new Markdown renderer. |
spliffone
left a comment
spliffone
left a comment
There was a problem hiding this comment.
I love it, the changes make totally sense and improve the security.
5eaeeb3 to
f4fa912
Compare
|
And the follow-up will be removing si-markdown-renderer. Or should I fold into this PR? |
|
@spliffone any more comments on this one, or can I proceed and merge? @dr-itz I think since this is ready, lets remove it in a follow-up. |
…ction BREAKING CHANGE: For `si-ai-message` and `si-user-message`, the `contentFormatter` input is no longer available. Instead use content projection. For markdown content, use the new `si-markdown` component.
f4fa912 to
5ec38fc
Compare
|
since there were two comments to address regarding testing, I folded the removal of si-markdown-renderer into this one. with schematics. |
…enderer BREAKING CHANGE: si-markdown-renderer and getMarkdownRenderer have been removed in favor of the new si-markdown component.
5ec38fc to
70156ba
Compare
|
@dr-itz This is awesome, I don't have anything to comment regarding the code changes. However, I think non of these commits should be /cc @spike-rabbit WDYT? |
5 participants
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: