Skip to content

feat(side-panel): support inner navigation - #2582

Open
mistrykaran91 wants to merge 1 commit into
mainfrom
2381-side-panel-inner-navigation
Open

feat(side-panel): support inner navigation#2582
mistrykaran91 wants to merge 1 commit into
mainfrom
2381-side-panel-inner-navigation

Conversation

@mistrykaran91

@mistrykaran91 mistrykaran91 commented Aug 18, 2026

Copy link
Copy Markdown
Member

Add an optional back button with a configurable label, output, and focus API.

Fixes #2381


Documentation.
Examples.
Dashboards Demo.
Playwright report.

Coverage Reports:

Code Coverage

@mistrykaran91 mistrykaran91 linked an issue Aug 18, 2026 that may be closed by this pull request
2 tasks
@mistrykaran91
mistrykaran91 force-pushed the 2381-side-panel-inner-navigation branch from 65b5b5c to 1f45727 Compare August 18, 2026 13:17
@mistrykaran91
mistrykaran91 force-pushed the 2381-side-panel-inner-navigation branch from 3b9f1b6 to 424bf61 Compare August 19, 2026 10:07
@mistrykaran91
mistrykaran91 marked this pull request as ready for review August 19, 2026 11:11
@mistrykaran91
mistrykaran91 requested review from a team and ljanner as code owners August 19, 2026 11:11
@mistrykaran91
mistrykaran91 requested a review from dr-itz August 20, 2026 04:28
Comment thread playwright/e2e/element-examples/si-side-panel.spec.ts Outdated
@mistrykaran91
mistrykaran91 force-pushed the 2381-side-panel-inner-navigation branch from b316536 to 4962677 Compare August 21, 2026 11:45
@spike-rabbit
spike-rabbit requested a review from panch1739 August 21, 2026 13:48

@panch1739 panch1739 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mistrykaran91 Hello!

The back button looks perfect, but the example is incorrect.

If we want to use the chat history as an example, the correct flow would be to first have a regular chat and then access the chat history:

Image

Refer to Figma

If this is too complicated, maybe we can simplify the example. We can show a regular list and it's details. E.g,:

Screenshot 2026-08-24 at 10 19 26

Something like the original request: #2381

Add an optional back button with a configurable label, output, and focus API.

Fixes #2381
@mistrykaran91
mistrykaran91 force-pushed the 2381-side-panel-inner-navigation branch from 2e5b259 to 7e78030 Compare August 25, 2026 07:07

@panch1739 panch1739 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mistrykaran91 Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Side panel inner navigation

4 participants