feat(system-banner): update system banner typography and dimensions - #2572
feat(system-banner): update system banner typography and dimensions#2572mistrykaran91 wants to merge 1 commit into
Conversation
68e383a to
3a0b0d0
Compare
spliffone
left a comment
spliffone
left a comment
There was a problem hiding this comment.
Does it make sense to adjust the commit message so the reader become aware the text is no longer bold?
f6e9573 to
4655843
Compare
mistrykaran91
added
ux
spike-rabbit
left a comment
spike-rabbit
left a comment
There was a problem hiding this comment.
@kfenner our initial plan to just make applications use the plain class for a system banner to add a link does not really work, as the styling is bound to the component.
What about we just move this to the theme? Then the absolute positioning is not needed
panch1739
left a comment
panch1739
left a comment
There was a problem hiding this comment.
@mistrykaran91 Sorry, one note...in the example with link, the link should be part of the text, so it would actually be center aligned. We should also is the underline for the link, so is recognizable.
is basically the same that we do in our inner source docs
- Use body text styling instead of body-bold. - Adjust banner spacing for a 24px height. - Add a system banner example with a link.
37be3bd to
1a6d71e
Compare
| aria-live="assertive" | ||
| > | ||
| {{ message() | translate }} | ||
| {{ message() | translate }} <ng-content select="a" /> |
There was a problem hiding this comment.
I think instead of this, we just want to allow any content inside based on my understanding, so:
| {{ message() | translate }} <ng-content select="a" /> | |
| <ng-content>{{ message() | translate }}</ng-content> |
4 participants
Closes #2491
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: