Skip to content

fix: Make BooleanType handle 0 correctly #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
njakobsen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Make BooleanType handle 0 correctly #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions lib/click_house/type/boolean_type.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,14 @@ module Type
class BooleanType < BaseType
TRUE_VALUE = 1
FALSE_VALUE = 0
TRUE_VALUES = Set[1, '1', true].freeze

def cast(value)
case value
when TrueClass, FalseClass
value
else
value.to_i == TRUE_VALUE
end
TRUE_VALUES.include?(value)
end

def serialize(value)
value ? TRUE_VALUE : FALSE_VALUE
TRUE_VALUES.include?(value) ? TRUE_VALUE : FALSE_VALUE
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions spec/click_house/integration/boolean_type_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
expect(got.fetch('a')).to be_a(TrueClass)
expect(got.fetch('b')).to be_a(FalseClass)
expect(got.fetch('c')).to be_a(TrueClass)
expect(got.fetch('b')).to be_a(FalseClass)
expect(got.fetch('d')).to be_a(FalseClass)
expect(got.fetch('e')).to be_a(NilClass)
end
end
Expand All @@ -58,7 +58,7 @@
expect(got.fetch('a')).to be_a(TrueClass)
expect(got.fetch('b')).to be_a(FalseClass)
expect(got.fetch('c')).to be_a(TrueClass)
expect(got.fetch('b')).to be_a(FalseClass)
expect(got.fetch('d')).to be_a(FalseClass)
expect(got.fetch('e')).to be_a(NilClass)
end
end
Expand Down