fix: improve UX feedback, memoization consistency, and docs accuracy#1
Open
eren-karakus0 wants to merge 3 commits intoshelby:mainfrom
Open
fix: improve UX feedback, memoization consistency, and docs accuracy#1eren-karakus0 wants to merge 3 commits intoshelby:mainfrom
eren-karakus0 wants to merge 3 commits intoshelby:mainfrom
Conversation
- Add toast notifications for clipboard copy actions in Header (wallet address and storage account address) - Wrap handleFileChange in useCallback for memoization consistency with other handlers in BlobUploader - Simplify uploaded blob list key prop (blob names are already unique due to duplicate check, removing unnecessary index) - Fix README Node.js version requirement (18+ -> 22+) to match the engines field in package.json
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
bem1102
added a commit
to bem1102/shelby-ai-web-starter
that referenced
this pull request
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four targeted improvements to code quality and user experience:
sonnerfor toasts, but the copy actions had no user feedback.handleFileChangeinuseCallbackin BlobUploader to match the pattern used by all other event handlers (handleUpload,handleFileInputClick).keyfrom`${blob.name}-${index}`toblob.name, since blob names are enforced unique by the duplicate check. Removes the array index anti-pattern.enginesfield inpackage.json.Changes
src/components/Header.tsxtoast.success()on clipboard copy, importtoastfrom sonnersrc/components/BlobUploader.tsxhandleFileChangeinuseCallback, simplifykeypropREADME.mdTest plan
Note
Low Risk
Changes are limited to UI feedback, React memoization/key hygiene, and documentation; no protocol/auth/data-flow logic is altered.
Overview
Improves small UX and React correctness details across the demo.
In
Header, copy-to-clipboard actions for wallet and storage addresses are nowasyncand showsonnersuccess toasts after copying.In
BlobUploader,handleFileChangeis wrapped inuseCallback(matching other handlers) and the uploaded blob listkeyis simplified toblob.namenow that duplicates are prevented. The README prerequisite is updated from Node 18+ to Node 22+.Written by Cursor Bugbot for commit befe4c9. This will update automatically on new commits. Configure here.