feat(swapper): add Fynd POC integration - #12528
Open
Masha-lla wants to merge 3 commits into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughFynd is added as an Ethereum swapper with quote, rate, fee, transaction, API, and status handling. Shared registries, exports, feature flags, environment configuration, CSP rules, development proxying, and the swapper icon are updated. ChangesFynd swapper
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant TradeRequest
participant getTradeQuote
participant fetchFromFynd
participant FyndAPI
participant getFyndStepData
participant EVMExecutor
TradeRequest->>getTradeQuote: submit trade input
getTradeQuote->>fetchFromFynd: request Fynd quote
fetchFromFynd->>FyndAPI: retrieve router and quote
FyndAPI-->>fetchFromFynd: return quote response
fetchFromFynd-->>getTradeQuote: return validated quote
getTradeQuote->>getFyndStepData: build transaction and fees
getFyndStepData-->>getTradeQuote: return transaction step
TradeRequest->>EVMExecutor: execute transaction
Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Masha-lla
marked this pull request as ready for review
August 5, 2026 15:00
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (2)
packages/swapper/src/swappers/FyndSwapper/getTradeRate/getTradeRate.ts (1)
59-72: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueDestructure the step data once.
Line 70 calls
maybeStepData.unwrap()a second time inside the object literal. Destructure it after the error check, asgetTradeQuotedoes.♻️ Proposed refactor
if (maybeStepData.isErr()) return Err(maybeStepData.unwrapErr()) + const { networkFeeCryptoBaseUnit } = maybeStepData.unwrap() const tradeRate: TradeRate = { ...tradeCommon, quoteOrRate: 'rate', receiveAddress: input.receiveAddress, steps: [ { ...stepCommon, accountNumber: input.accountNumber, - feeData: { - networkFeeCryptoBaseUnit: maybeStepData.unwrap().networkFeeCryptoBaseUnit, - protocolFees, - }, + feeData: { networkFeeCryptoBaseUnit, protocolFees }, }, ] as SingleHopTradeRateSteps, }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/swapper/src/swappers/FyndSwapper/getTradeRate/getTradeRate.ts` around lines 59 - 72, In the getTradeRate flow, after the maybeStepData.isErr() check, destructure the successful step data once and use that local value for networkFeeCryptoBaseUnit in the tradeRate object instead of calling maybeStepData.unwrap() again. Keep the existing error propagation and tradeRate construction unchanged.packages/swapper/src/swappers/FyndSwapper/utils/helpers.ts (1)
20-24: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse action-oriented function names.
The current names describe a conversion pattern or implementation pattern instead of the action.
packages/swapper/src/swappers/FyndSwapper/utils/helpers.ts#L20-L24: renameassetIdToFyndTokentoconvertAssetIdToFyndToken.packages/swapper/src/swappers/FyndSwapper/utils/fyndService.ts#L8-L18: renamefyndServiceFactorytocreateFyndService.As per coding guidelines, “Use verb prefixes for functions that perform actions.”
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/swapper/src/swappers/FyndSwapper/utils/helpers.ts` around lines 20 - 24, Rename assetIdToFyndToken to convertAssetIdToFyndToken in packages/swapper/src/swappers/FyndSwapper/utils/helpers.ts and update all references. Rename fyndServiceFactory to createFyndService in packages/swapper/src/swappers/FyndSwapper/utils/fyndService.ts and update all references.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/swapper/src/constants.ts`:
- Around line 108-111: Update the swappers registry entry for SwapperName.Fynd
to conditionally include the combined fyndSwapper and fyndApi exports only when
VITE_FEATURE_FYND_SWAP is enabled. Add or reuse the public API
environment/config flag used by constants.ts, and ensure disabled configurations
omit the Fynd entry entirely rather than merely hiding it in UI selectors.
In `@packages/swapper/src/swappers/FyndSwapper/getTradeQuote/getTradeQuote.ts`:
- Around line 45-52: Update the validation in getTradeQuote so quotes are
rejected only when quote.transaction is missing; allow absent fee_breakdown so
getFyndTradeContext can apply its existing router and client fee fallbacks. Keep
the executable-step construction unchanged, or, if the quote contract guarantees
fee_breakdown, remove that fallback in getFyndTradeContext and align both paths
to require it.
In `@packages/swapper/src/swappers/FyndSwapper/utils/fetchFromFynd.ts`:
- Around line 44-47: Update fetchFromFynd to runtime-validate both
FyndInfoResponse and FyndQuoteResponse before using or returning quote data:
require an Ethereum info response with a valid router_address, require
transaction and fee_breakdown, and require all quote amounts and fees to be
numeric and non-negative. Convert every rejected shape to
TradeQuoteError.InvalidResponse, and add tests covering each invalid response
case.
In `@packages/swapper/src/swappers/FyndSwapper/utils/getFyndStepData.ts`:
- Around line 29-35: Update the rate branch in getFyndStepData to use the shared
getEvmNetworkFeeCryptoBaseUnit path, passing the provider gas_estimate as
gasLimit and preserving the provider gas price handling so null values are not
silently converted into a zero network fee; alternatively, explicitly reject
null gas prices instead of defaulting them.
In `@packages/swapper/src/swappers/FyndSwapper/utils/helpers.ts`:
- Around line 20-88: Add explicit return types to assetIdToFyndToken,
assertValidTrade, calculateFyndRouterFee, calculateFyndAmounts,
calculateFyndRate, and isNativeFyndSell in helpers.ts, using a named object type
for calculateFyndAmounts; add the SwapErrorRight return type to
quoteStatusToError in fetchFromFynd.ts. Then run pnpm run lint --fix and pnpm
run type-check.
---
Nitpick comments:
In `@packages/swapper/src/swappers/FyndSwapper/getTradeRate/getTradeRate.ts`:
- Around line 59-72: In the getTradeRate flow, after the maybeStepData.isErr()
check, destructure the successful step data once and use that local value for
networkFeeCryptoBaseUnit in the tradeRate object instead of calling
maybeStepData.unwrap() again. Keep the existing error propagation and tradeRate
construction unchanged.
In `@packages/swapper/src/swappers/FyndSwapper/utils/helpers.ts`:
- Around line 20-24: Rename assetIdToFyndToken to convertAssetIdToFyndToken in
packages/swapper/src/swappers/FyndSwapper/utils/helpers.ts and update all
references. Rename fyndServiceFactory to createFyndService in
packages/swapper/src/swappers/FyndSwapper/utils/fyndService.ts and update all
references.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: fdc11f3c-03d1-4114-9f2a-d1d93cb65f8b
⛔ Files ignored due to path filters (1)
src/components/MultiHopTrade/components/TradeInput/components/SwapperIcon/fynd-icon.svgis excluded by!**/*.svg
📒 Files selected for processing (29)
.env.env.development.env.productionheaders/csps/defi/swappers/Fynd.tsheaders/csps/index.tspackages/public-api/src/config.tspackages/swapper/src/constants.tspackages/swapper/src/index.tspackages/swapper/src/swappers/FyndSwapper/FyndSwapper.tspackages/swapper/src/swappers/FyndSwapper/endpoints.tspackages/swapper/src/swappers/FyndSwapper/getTradeQuote/getTradeQuote.tspackages/swapper/src/swappers/FyndSwapper/getTradeRate/getTradeRate.tspackages/swapper/src/swappers/FyndSwapper/index.tspackages/swapper/src/swappers/FyndSwapper/types.tspackages/swapper/src/swappers/FyndSwapper/utils/constants.tspackages/swapper/src/swappers/FyndSwapper/utils/fetchFromFynd.tspackages/swapper/src/swappers/FyndSwapper/utils/fyndService.tspackages/swapper/src/swappers/FyndSwapper/utils/getFyndStepData.tspackages/swapper/src/swappers/FyndSwapper/utils/getFyndTradeContext.tspackages/swapper/src/swappers/FyndSwapper/utils/helpers.test.tspackages/swapper/src/swappers/FyndSwapper/utils/helpers.tspackages/swapper/src/types.tssrc/components/MultiHopTrade/components/TradeInput/components/SwapperIcon/SwapperIcon.tsxsrc/config.tssrc/state/helpers.tssrc/state/slices/preferencesSlice/preferencesSlice.tssrc/test/mocks/store.tssrc/vite-env.d.tsvite.config.mts
Comment on lines
+108
to
+111
| [SwapperName.Fynd]: { | ||
| ...fyndSwapper, | ||
| ...fyndApi, | ||
| }, |
Contributor
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n -C 8 'SwapperName\.Fynd|VITE_FEATURE_FYND_SWAP|fyndApi|fyndSwapper' \
src packages/public-api packages/swapperRepository: shapeshift/web
Length of output: 22478
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== swapper registry consumers =="
rg -n "swapperRegistry\)|getSwapper\(|executeEvmTransaction\(|getUnsignedEvmTransaction\(|getTradeQuote\(|getTradeRate\(|checkTradeStatus\(|getEvmTransactionFees\(" packages src --glob '*.ts' --glob '*.tsx' | head -n 240
echo
echo "== constants outline/section =="
cat -n packages/swapper/src/constants.ts | sed -n '1,220p'
echo
echo "== public API files =="
git ls-files packages/public-api | sortRepository: shapeshift/web
Length of output: 18303
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== selector helpers around Fynd =="
cat -n src/state/helpers.ts | sed -n '1,130p'
echo
echo "== preferences slice around Fynd =="
cat -n src/state/slices/preferencesSlice/preferencesSlice.ts | sed -n '210,255p'
echo
echo "== feature flag references concise =="
rg -n "FyndSwap|VITE_FEATURE_FYND_SWAP|SwapperName\.Fynd|getAvailable.*Swapper|is.*Swapper" src packages/swapper packages/public-api --glob '*.ts' --glob '*.tsx' | head -n 240Repository: shapeshift/web
Length of output: 19607
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== swapper registry exported/use site =="
cat -n packages/swapper/src/swapper.ts | sed -n '1,110p'
echo
echo "== public-api swapper deps and index =="
cat -n packages/public-api/src/swapperDeps.ts | sed -n '1,220p'
echo
cat -n packages/public-api/src/index.ts | sed -n '1,220p'
echo
echo "== public-api route quote/rate/index =="
cat -n packages/public-api/src/routes/quote/getQuote.ts | sed -n '1,180p'
echo
cat -n packages/public-api/src/routes/rates/getRates.ts | sed -n '1,180p'
echo
cat -n packages/public-api/src/routes/quote/index.ts | sed -n '1,180p'
echo
cat -n packages/public-api/src/routes/rates/index.ts | sed -n '1,180p'
echo
echo "== public-api registry/status =="
cat -n packages/public-api/src/registry.ts | sed -n '1,220p'
echo
cat -n packages/public-api/src/routes/status/getSwapStatus.ts | sed -n '1,220p'
echo
cat -n packages/public-api/src/routes/status/index.ts | sed -n '1,220p'Repository: shapeshift/web
Length of output: 39202
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== public-api env/config =="
cat -n packages/public-api/src/env.ts | sed -n '1,220p'
echo
echo "== public-api config feature constants =="
cat -n packages/public-api/src/config.ts | sed -n '1,260p'
echo
echo "== public-api constants enabled swapper env =="
cat -n packages/public-api/src/constants.ts | sed -n '1,220p'
echo
echo "== public-api docs mentioning Fynd/swapper names =="
rg -n "SwapperName|Fynd|enabled|ENABLED|quote/status/rates" packages/public-api/docs --glob '*.md'Repository: shapeshift/web
Length of output: 9015
Security And Privacy (CWE-16)
Reachability: Internal · Exploitability: Moderate
Reachability path
● Entry
packages/swapper/src/swappers/FyndSwapper/getTradeQuote/getTradeQuote.ts:19
getTradeQuote
│
▼
● Sink
packages/swapper/src/constants.ts
Gate the Fynd registry entry with VITE_FEATURE_FYND_SWAP.
packages/swapper/src/constants.ts exports fyndSwapper and fyndApi directly into swappers[SwapperName.Fynd], making quote/rate/unsigned transaction methods reachable through public API paths. Add public-API env/config support for this flag and skip exporting Fynd unless it is enabled, instead of relying only on app selectors/UI gating.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/swapper/src/constants.ts` around lines 108 - 111, Update the
swappers registry entry for SwapperName.Fynd to conditionally include the
combined fyndSwapper and fyndApi exports only when VITE_FEATURE_FYND_SWAP is
enabled. Add or reuse the public API environment/config flag used by
constants.ts, and ensure disabled configurations omit the Fynd entry entirely
rather than merely hiding it in UI selectors.
Comment on lines
+29
to
+35
| if (args.type === 'rate') { | ||
| return Ok({ | ||
| networkFeeCryptoBaseUnit: bnOrZero(args.gasEstimate) | ||
| .times(args.gasPrice ?? '0') | ||
| .toFixed(), | ||
| }) | ||
| } |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify the rate-mode argument shape of getEvmNetworkFeeCryptoBaseUnit and how other swappers use it.
fd 'getEvmNetworkFeeCryptoBaseUnit.ts' --exec cat -n
rg -nP -C6 'getEvmNetworkFeeCryptoBaseUnit\(\{' packages/swapper/srcRepository: shapeshift/web
Length of output: 39041
🏁 Script executed:
#!/bin/bash
# Inspect the Fynd step-data implementation and the Fynd types that define gas estimates and prices.
fd getFyndStepData.ts packages/swapper/src/swappers/FyndSwapper --exec cat -n
rg -n "gasPrice|gas_estimate|gas_price|gasEstimate|getFyndStepData" packages/swapper/src/swappers/FyndSwapper packages/swapper/src -C 3Repository: shapeshift/web
Length of output: 44312
Use the shared EVM rate fee path for Fynd.
quote.gas_price can be null, which makes getFyndStepData return a zero network fee. Call getEvmNetworkFeeCryptoBaseUnit from the rate branch using the provider gas_estimate as gasLimit, or reject null instead of defaulting it to '0'.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/swapper/src/swappers/FyndSwapper/utils/getFyndStepData.ts` around
lines 29 - 35, Update the rate branch in getFyndStepData to use the shared
getEvmNetworkFeeCryptoBaseUnit path, passing the provider gas_estimate as
gasLimit and preserving the provider gas price handling so null values are not
silently converted into a zero network fee; alternatively, explicitly reject
null gas prices instead of defaulting them.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (3)
packages/swapper/src/swappers/FyndSwapper/utils/validation.test.ts (1)
6-39: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winType and rename the test fixtures.
Rename
transaction,feeBreakdown,order, andresponseto descriptiveUPPER_SNAKE_CASEconstants. Define named fixture types from the Fynd response contracts.Rename
valuetoinvalidInfoResponse. Add explicit callback parameter types for bothit.eachhandlers.As per coding guidelines,
Use UPPER_SNAKE_CASE for constants and configuration values with descriptive names,ALWAYS use explicit types for object shapes using interfaces or type aliases in TypeScript, andAvoid non-descriptive variable names like data, item, obj, and single-letter variable names except in loops.Also applies to: 53-83
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/swapper/src/swappers/FyndSwapper/utils/validation.test.ts` around lines 6 - 39, Rename the test fixtures transaction, feeBreakdown, order, response, and value to descriptive UPPER_SNAKE_CASE constants, using invalidInfoResponse for value. Define named interfaces or type aliases based on the Fynd response contracts for each fixture’s object shape, apply those types explicitly, and add explicit callback parameter types to both it.each handlers.Source: Coding guidelines
packages/swapper/src/swappers/FyndSwapper/utils/validation.ts (1)
50-56: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winKeep external response arrays typed as
unknown[].
Array.isArray()narrowsvalue.swapsandvalue.orderstoany[]. Theswapandordercallback parameters then bypass the required external-payload type safety.Add an
isUnknownArrayguard or explicitly narrow the arrays tounknown[]. MakeisValidOrdera type guard before the final response cast.As per coding guidelines,
NEVER use any type unless absolutely necessary in TypeScript,ALWAYS use explicit types for function parameters and return values in TypeScript, andALWAYS create custom type guards for complex types in TypeScript.Also applies to: 115-127
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/swapper/src/swappers/FyndSwapper/utils/validation.ts` around lines 50 - 56, Update isValidRoute and isValidOrder to prevent Array.isArray from producing any[]: narrow swaps and orders to unknown[] using an isUnknownArray guard or equivalent explicit narrowing, and annotate callback parameters explicitly. Make isValidOrder a type guard so the final external response cast is safely based on validated data.Source: Coding guidelines
packages/swapper/src/swappers/FyndSwapper/utils/fyndService.ts (1)
8-8: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse a named service configuration type.
Replace the inline
{ baseUrl: string }parameter type with a descriptiveFyndServiceConfigtype.As per coding guidelines,
ALWAYS use explicit types for object shapes using interfaces or type aliases in TypeScript.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/swapper/src/swappers/FyndSwapper/utils/fyndService.ts` at line 8, Introduce a named FyndServiceConfig type alias or interface for the service options object, then update createFyndService to use FyndServiceConfig instead of the inline { baseUrl: string } parameter type.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/swapper/src/swappers/FyndSwapper/utils/validation.ts`:
- Around line 42-48: Extend the fee-breakdown validation and successful-quote
path around isValidFeeBreakdown and calculateFyndAmounts to ensure router_fee
plus client_fee does not exceed amount_out; reject such quotes before amount
calculation can produce a negative buyAmountAfterFeesCryptoBaseUnit. Add a
regression test covering a quote whose combined fees exceed the quoted output.
- Around line 24-25: Update isNonNegativeNumericString to accept only non-empty
strings representing non-negative decimal integers in base-unit fields. Reject
fractional and exponent notation such as “0.5” and “1.23e-1” before the
bn(value) checks, while preserving acceptance of valid unsigned integer strings.
---
Nitpick comments:
In `@packages/swapper/src/swappers/FyndSwapper/utils/fyndService.ts`:
- Line 8: Introduce a named FyndServiceConfig type alias or interface for the
service options object, then update createFyndService to use FyndServiceConfig
instead of the inline { baseUrl: string } parameter type.
In `@packages/swapper/src/swappers/FyndSwapper/utils/validation.test.ts`:
- Around line 6-39: Rename the test fixtures transaction, feeBreakdown, order,
response, and value to descriptive UPPER_SNAKE_CASE constants, using
invalidInfoResponse for value. Define named interfaces or type aliases based on
the Fynd response contracts for each fixture’s object shape, apply those types
explicitly, and add explicit callback parameter types to both it.each handlers.
In `@packages/swapper/src/swappers/FyndSwapper/utils/validation.ts`:
- Around line 50-56: Update isValidRoute and isValidOrder to prevent
Array.isArray from producing any[]: narrow swaps and orders to unknown[] using
an isUnknownArray guard or equivalent explicit narrowing, and annotate callback
parameters explicitly. Make isValidOrder a type guard so the final external
response cast is safely based on validated data.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: c50935c0-3c0d-4e9f-8715-589432acc8cf
📒 Files selected for processing (8)
packages/swapper/src/swappers/FyndSwapper/getTradeQuote/getTradeQuote.tspackages/swapper/src/swappers/FyndSwapper/getTradeRate/getTradeRate.tspackages/swapper/src/swappers/FyndSwapper/utils/fetchFromFynd.tspackages/swapper/src/swappers/FyndSwapper/utils/fyndService.tspackages/swapper/src/swappers/FyndSwapper/utils/getFyndStepData.tspackages/swapper/src/swappers/FyndSwapper/utils/helpers.tspackages/swapper/src/swappers/FyndSwapper/utils/validation.test.tspackages/swapper/src/swappers/FyndSwapper/utils/validation.ts
🚧 Files skipped from review as they are similar to previous changes (3)
- packages/swapper/src/swappers/FyndSwapper/getTradeQuote/getTradeQuote.ts
- packages/swapper/src/swappers/FyndSwapper/utils/fetchFromFynd.ts
- packages/swapper/src/swappers/FyndSwapper/utils/getFyndStepData.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This proof of concept adds Fynd as an Ethereum same-chain swapper for exact-input trades.
VITE_FEATURE_FYND_SWAP/infoand/quoteAPIsThis is intentionally a POC. It currently targets Ethereum mainnet only, omits affiliate fee signing, and does not enable Fynd in production.
Issue (if applicable)
N/A — exploratory POC based on the Fynd integration proposal.
Risk
High if enabled: this introduces a new EVM transaction source and approval target. The feature remains disabled in production and should not be merged for production use without a security review, transaction regression testing, and two approvals.
Affected behavior is limited to Ethereum exact-input swaps routed through Fynd when the feature flag is enabled. Existing swappers remain unchanged.
Testing
Engineering
Validated locally with the feature flag enabled and a server-side hosted Fynd API key:
pnpm run dev:web:localhost.http://127.0.0.1:3000.Fynd • ekubo_v3, output amounts are populated, and network fees are displayed.Automated checks:
pnpm exec eslint vite.config.mts packages/swapper/src/swappers/FyndSwapper packages/swapper/src/constants.ts packages/swapper/src/types.ts packages/public-api/src/config.ts src/config.ts src/state/helpers.ts src/state/slices/preferencesSlice/preferencesSlice.ts src/test/mocks/store.ts src/components/MultiHopTrade/components/TradeInput/components/SwapperIcon/SwapperIcon.tsx --fixpnpm exec tsc --noEmit -p packages/swapper/tsconfig.esm.jsonpnpm exec vitest run packages/swapper/src/swappers/FyndSwapper/utils/helpers.test.tsThe root type-check is currently blocked by pre-existing missing package build artifacts (
TS6305) after the monorepo clean step; the swapper-specific type-check passes.No transaction was signed or broadcast during browser verification.
Operations
Screenshots (if applicable)
N/A
Summary by CodeRabbit