Skip to content

fix(cosmossdk): reject malformed tx history cursor at request boundary #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaladinlight merged 1 commit into from
Jun 12, 2026
Merged

fix(cosmossdk): reject malformed tx history cursor at request boundary #1279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions go/shared/cosmossdk/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,22 @@ func (a *API) Root(w http.ResponseWriter, r *http.Request) {
func (a *API) ValidatePagingParams(w http.ResponseWriter, r *http.Request, defaultPageSize int, maxPageSize *int) (string, int, error) {
cursor := r.URL.Query().Get("cursor")

if cursor != "" {
c := &Cursor{}
if err := c.Decode(cursor); err != nil {
api.HandleError(w, http.StatusBadRequest, "invalid cursor")
return cursor, 0, fmt.Errorf("invalid cursor: %w", err)
}

// reject nil state entries to avoid a downstream nil pointer dereference
for source, state := range c.State {
if state == nil {
api.HandleError(w, http.StatusBadRequest, "invalid cursor")
return cursor, 0, fmt.Errorf("invalid cursor: nil state for source %q", source)
}
}
}

pageSizeQ := r.URL.Query().Get("pageSize")
if pageSizeQ == "" {
pageSizeQ = strconv.Itoa(defaultPageSize)
Expand Down
Loading