fix(a11y): improve destructive alert description contrast in v4#10432
Open
galoi wants to merge 1 commit intoshadcn-ui:mainfrom
Open
fix(a11y): improve destructive alert description contrast in v4#10432galoi wants to merge 1 commit intoshadcn-ui:mainfrom
galoi wants to merge 1 commit intoshadcn-ui:mainfrom
Conversation
Contributor
|
Someone is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
text-destructive/90withtext-destructivefor destructive Alert descriptions innew-york-v4Why
Issue #10431 reports that the destructive Alert description color sits on the WCAG AA threshold against the default white card background. The current
text-destructive/90value reduces contrast enough that downstream accessibility tooling can report a failure for normal body text.Root Cause
The destructive Alert variant explicitly applies a 90% alpha destructive text color to the description slot. With the documented default theme tokens, that lowers the effective foreground/background contrast to the edge of the AA minimum.
Impact
Destructive Alert descriptions now use the full destructive token instead of the alpha-reduced variant, giving the component more contrast headroom with the default theme while preserving the existing visual intent.
Validation
pnpm --filter=shadcn buildpnpm --filter=v4 lintpnpm exec prettier --check 'apps/v4/registry/new-york-v4/ui/alert.tsx' 'apps/v4/registry/styles/style-*.css' 'apps/v4/styles/*/ui/alert.tsx' 'apps/v4/styles/*/ui-rtl/alert.tsx' 'apps/v4/public/r/styles/*/alert.json'Closes #10431