fix: guard against undefined event.key in ThemeHotkey (fixes #10378)#10404
Open
armorbreak001 wants to merge 1 commit intoshadcn-ui:mainfrom
Open
fix: guard against undefined event.key in ThemeHotkey (fixes #10378)#10404armorbreak001 wants to merge 1 commit intoshadcn-ui:mainfrom
armorbreak001 wants to merge 1 commit intoshadcn-ui:mainfrom
Conversation
Contributor
|
@armorbreak001 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The ThemeHotkey component in the generated theme-provider.tsx template attaches a global keydown listener. During browser autofill/autocomplete on Chrome and Edge, a synthetic keydown event is fired where event.key is undefined. The listener calls event.key.toLowerCase() without a null-check, causing an uncaught TypeError.
Solution
Add a guard that checks event.key is truthy before calling .toLowerCase().
Changes
Verification