docs(drawer): add asChild on DrawerClose in Usage example#10403
Closed
MukundaKatta wants to merge 1 commit intoshadcn-ui:mainfrom
Closed
docs(drawer): add asChild on DrawerClose in Usage example#10403MukundaKatta wants to merge 1 commit intoshadcn-ui:mainfrom
asChild on DrawerClose in Usage example#10403MukundaKatta wants to merge 1 commit intoshadcn-ui:mainfrom
Conversation
The Usage example wraps a `<Button>` inside a `<DrawerClose>`
without `asChild`. Because `DrawerClose` renders a `<button>` by
default and `Button` also renders a `<button>`, copy-pasting the
example produces a nested `<button><button>` tree and React 19
raises a hydration error:
In HTML, <button> cannot be a descendant of <button>.
Adding `asChild` delegates rendering to the child so only one
`<button>` ends up in the DOM, matching the pattern already used
by `DialogClose`, `AlertDialogCancel`, and other Radix primitives
elsewhere in the docs.
Fix applied to both the Radix and Base variants of the drawer doc.
Fixes shadcn-ui#6205
Contributor
|
@MukundaKatta is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Withdrawing — low-value drive-by change. Apologies for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Drawer Usage example wraps a
<Button>inside a<DrawerClose>withoutasChild:Because
DrawerCloserenders a<button>by default andButtonalso renders a<button>, copy-pasting the example produces a nested<button><button>tree and React raises a hydration error:Adding
asChilddelegates rendering to the child so only one<button>ends up in the DOM — matching the pattern already used byDialogClose,AlertDialogCancel, and other Radix primitives elsewhere in the docs.Fix applied to both the Radix and Base variants of the drawer doc:
apps/v4/content/docs/components/radix/drawer.mdxapps/v4/content/docs/components/base/drawer.mdxFixes #6205
Test plan
asChildusage already present in sibling close-button docs