fix(accordion): allow radix content to grow dynamically#10388
Open
ElhamDevelopmentStudio wants to merge 1 commit intoshadcn-ui:mainfrom
Open
fix(accordion): allow radix content to grow dynamically#10388ElhamDevelopmentStudio wants to merge 1 commit intoshadcn-ui:mainfrom
ElhamDevelopmentStudio wants to merge 1 commit intoshadcn-ui:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10336
Summary
Removes the fixed
--radix-accordion-content-heightheight from the inner Radix accordion content wrapper.The outer
AccordionPrimitive.Contentwrapper still handles the open/close animation, but the inner content is no longer locked to a fixed height, so dynamically growing content does not get clipped after the accordion opens.Testing
corepack pnpm --filter=shadcn buildcorepack pnpm --filter=v4 exec tsx --tsconfig ./tsconfig.scripts.json ./scripts/build-registry.mtscorepack pnpm --filter=v4 typecheckcorepack pnpm --filter=v4 lint