feat(components): replace vaul drawer with base-ui drawer#10292
Closed
lunaxislu wants to merge 3 commits intoshadcn-ui:mainfrom
Closed
feat(components): replace vaul drawer with base-ui drawer#10292lunaxislu wants to merge 3 commits intoshadcn-ui:mainfrom
lunaxislu wants to merge 3 commits intoshadcn-ui:mainfrom
Conversation
Contributor
|
@lunaxislu is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Apr 9, 2026
7 tasks
Author
|
Superseded by #10430. The new PR starts fresh from the latest main with only drawer-related changes, restructured commits, and a clearer ownership model. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@base-ui/react.@base-ui/reactfrom1.1.0to1.3.0.Changes
registry/bases/base/ui/drawer.tsx- Rewritten using the@base-ui/react/drawerAPI.registry/bases/base/ui/_registry.ts- Changeddependencies: ["vaul"]to["@base-ui/react"].registry/bases/radix/ui/drawer.tsx- Kept the Radix drawer shell/classes under thecn-radix-drawer-*prefix.cn-radix-drawer-*,cn-base-ui-drawer-*, andcn-drawer-*.DrawerContent->DrawerPopup,direction->swipeDirection, andasChild->render.content/docs/components/base/drawer.mdx.registry:build(styles/base-*/ui/drawer.tsx,public/r/).Why
vauland Base UI use different dismiss contracts, so mixed stacks can produce race conditions around Escape and outside-click behavior. The base registry already uses Base UI for Dialog and AlertDialog, so Drawer is being aligned to the same model.API Migration
direction="bottom"swipeDirection="down"DrawerContent(includes portal + overlay)DrawerPopupasChildrenderpropdata-vaul-drawer-directiondata-swipe-directionTest Plan
pnpm registry:build- passedpnpm typecheck- passedpnpm lint- passedpnpm dev- manually verified the drawer examples (demo,dialog,rtl,scrollable-content,sides)Preview
https://ui-forge-web.vercel.app/base-ui/drawer
demo,dialog,rtl,scrollable-content, andsidesexamples.Context
If this is not the direction the shadcn team wants, or if there are any additional details I should verify for this component, please leave a comment. I'm happy to adjust the scope or close the PR if needed.