Skip to content

chore: add dco check #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Syspretor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: add dco check #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,4 @@ fixes #XXXX
- [ ] Format your code `make fmt`.
- [ ] Add unit tests or integration tests.
- [ ] Update the documentation related to the change.
- [ ] All commits are signed with DCO (`git commit -s`). See [Developer Certificate of Origin (DCO)](CONTRIBUTING.md#developer-certificate-of-origin-dco).

@gemini-code-assist gemini-code-assist Bot Apr 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There are two minor improvements for this new checklist item:

  1. Terminology: Use "signed-off" instead of "signed". DCO (Developer Certificate of Origin) specifically uses the Signed-off-by trailer (added via git commit -s), whereas "signed" often implies GPG/SSH signatures (git commit -S). This aligns with the terminology used in CONTRIBUTING.md (e.g., line 104).
  2. Link Path: Since this template is located in the .github/ subdirectory, the relative link to CONTRIBUTING.md should be ../CONTRIBUTING.md to ensure it works correctly when viewing the template file directly in the repository browser.
Suggested change
- [ ] All commits are signed with DCO (`git commit -s`). See [Developer Certificate of Origin (DCO)](CONTRIBUTING.md#developer-certificate-of-origin-dco).
- [ ] All commits are signed-off with DCO (`git commit -s`). See [Developer Certificate of Origin (DCO)](../CONTRIBUTING.md#developer-certificate-of-origin-dco).

24 changes: 24 additions & 0 deletions .github/workflows/dco-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: DCO Check

on:
pull_request:
branches: ["main"]

# Declare default permissions as read only.
permissions: read-all

jobs:
dco-check:
runs-on: ubuntu-latest
name: DCO Check
steps:
- name: Get PR Commits
id: get-pr-commits
uses: tim-actions/get-pr-commits@master
with:
token: ${{ secrets.GITHUB_TOKEN }}

- name: DCO Check
uses: tim-actions/dco@master
with:
commits: ${{ steps.get-pr-commits.outputs.commits }}
Loading