Remove redundant while loop break in dqn.py#58
Open
ginoperrotta wants to merge 1 commit intoseungeunrho:masterfrom
ginoperrotta:patch-1
Open
Remove redundant while loop break in dqn.py#58ginoperrotta wants to merge 1 commit intoseungeunrho:masterfrom ginoperrotta:patch-1
ginoperrotta wants to merge 1 commit intoseungeunrho:masterfrom
ginoperrotta:patch-1
Conversation
The training loop in dqn.py has both `while not done` and `if done: break`. This is harmless, but redundant. Given this repo's focus on minimalism, though, I thought the break statement should be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The training loop in dqn.py has both
while not doneandif done: break. This is harmless, but redundant. Given this repo's focus on minimalism, though, I thought the break statement should be removed.