config: support excluding images in environment variable.#170
Open
gabay wants to merge 1 commit into
Open
Conversation
Owner
|
Hey @gabay, thanks for taking the time to create this PR! I'm finally done with my final exams, so I hope to start working on Cup again soon (in addition to some other projects) and I'll probably completely rewrite it. I don't know if that will ever succeed or when, so I think we should get this merged. From my first really quick review (I'm not on my computer right now, sorry), I'll say the following:
I'll do a more thorough review later. It'd be great if you could fix these in the meantime! |
bccd628 to
cab6594
Compare
cab6594 to
b429d6c
Compare
Author
|
thanks for replying, I hope the exams went as well as could be :)
BTW - I used AI to create the initial draft for tis PR. IDK what's your take on it, I prefer to be clear about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: I read your note about pausing cup development. this PR is of no urgency whatsoever.
I came across a need to ignore just one image, and didn't want to create a config file just for that
example use in docker compose file - ignore postgres:16 and postgres:17 images: