Fix edgecase docker.io image reported as unused#169
Draft
AiroPi wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, to check if an image is used or not, the reference is checked.
This can cause edge-case issues with docker.io being masked by Docker.
To reproduce you can make this:
(Note the use of explicit
docker.io)The container will have
docker.io/hello-world:latestas image, and the image reference will behello-world:latest.This cause the image to be reported as unused because it will test
hello-world:latestagainstdocker.io/hello-world:latestwhich don't match.To address this issue, I change the comparison to use image id instead. It's my first time with rust btw.
(nb: I was not able to test for swarm so the image id is set as None for now)