Improves u128/i128 handling #1679
Closed
bkchr wants to merge 5 commits into
Closed
Conversation
Contributor
Contributor
Author
|
Yeah, I'm waiting for a review :) |
|
@dtolnay We have bumped into serde-rs/json#505 issue which is supposedly resolved by serde-rs/json#586 which seem to require this PR to be merged. I wonder if this is considered by design or it will eventually be fixed Thank you for your hard work! |
dtolnay
reviewed
Mar 15, 2020
Member
dtolnay
left a comment
dtolnay
left a comment
There was a problem hiding this comment.
Hi folks -- it looks like this PR was motivated by serde-rs/json#586 but unfortunately I wasn't able to accept that one, so I'll close this one as well. Thanks anyway! I am still interested in getting JSON arbitrary precision numbers working with the tag & flatten attributes but it seems it will need a somewhat different design.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides that it makes it possible to have
u128/i128in bufferedContent.