fix: KIP-394#1435
Open
piotrkowalczuk wants to merge 1 commit into
Open
Conversation
dc77da2 to
5134d5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConsumerGroupcould not join a group on brokers that enforce KIP-394. When the broker rejected the initialJoinGroupwithMEMBER_ID_REQUIREDand returned a freshly assigned member ID, the high-level consumer treated it as a fatal error and kept retrying with an empty member ID, never making progress.After this change,
ConsumerGroupcompletes the two-step handshake the KIP prescribes: onMEMBER_ID_REQUIRED, it re-sendsJoinGrouponce carrying the broker-assigned member ID, then proceeds normally.Behavior
JoinGroup, consumes normallyNo protocol-version changes. No public API changes. Defaults preserved.
Tests
docker_compose_versions/docker-compose-tansu-060.ymlfor running the existingConsumerGrouptest suite against Tansu, which exercises this code path. AKAFKA_VERSION=tansu-0.6.0env switch gates a single assertion that depends on Apache Kafka's generation-bump semantics, which Tansu does not match.