Make RegexGenerator generate unique values on consecutive reverse_transform calls - #1096
Open
fealho wants to merge 1 commit into
Open
Make RegexGenerator generate unique values on consecutive reverse_transform calls #1096fealho wants to merge 1 commit into
RegexGenerator generate unique values on consecutive reverse_transform calls #1096fealho wants to merge 1 commit into
Conversation
Contributor
fealho
force-pushed
the
issue-1091-regex-generator-uniqueness
branch
from
July 29, 2026 17:05
57fd749 to
317429a
Compare
fealho
marked this pull request as ready for review
July 29, 2026 17:06
fealho
requested review from
amontanez24 and
frances-h
and removed request for
a team
July 29, 2026 17:06
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1096 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 2718 2733 +15
=========================================
+ Hits 2718 2733 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fealho
force-pushed
the
issue-1091-regex-generator-uniqueness
branch
from
July 29, 2026 17:11
317429a to
ba4f0e6
Compare
pvk-developer
requested changes
Jul 31, 2026
Member
There was a problem hiding this comment.
I think that this introduced a bug with categorical values:
transformer = RegexGenerator(regex_format='[A-Da-d]', cardinality_rule='unique')
transformer.fit(pd.DataFrame(columns=['id']), 'id')
samples = pd.concat([transformer.reverse_transform(pd.DataFrame(index=[0])) for i in range(50)])['id']
samples
# output
0 A
0 B
0 C
0 D
0 a
0 b
0 c
0 d
0 d(0)
0 d(0)(0)
0 d(0)(0)(0)
........
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CU-86bav75gd, Resolve #1091