Escape environment variables, add things to the "docker create" container#66
Open
nalind wants to merge 4 commits intoscollier:masterfrom
Open
Escape environment variables, add things to the "docker create" container#66nalind wants to merge 4 commits intoscollier:masterfrom
nalind wants to merge 4 commits intoscollier:masterfrom
Conversation
Make building an image slightly faster by putting shorter label definitions on a single line.
Since 6784a772baaa20936f00b8adc00a4b4444356181 or so, environment variable values have been evaluated as part of processing LABEL statements at build-time. Since we want to preserve these for when the "atomic" command runs them, escape them.
When we're installing a container, add the cgroups hierarchy to the list of volumes it'll need, since we're using systemd's init as the container entry point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LABEL statements in Dockerfiles have environment variables interpolated into them, so we need to escape them so that they won't be prematurely evaluated by the builder, so that they can be evaluated by "atomic".
The container that we create during "atomic install" needs the cgroups hierarchy to be mounted, since it's using systemd's init as its entry point, and its port 80 exposed, both to also agree with how we tell "atomic" to run the image.