ENH: template-ify lambertw with overloads for double, float, and complex<float>#116
Open
kandersolar wants to merge 5 commits intoscipy:mainfrom
Open
ENH: template-ify lambertw with overloads for double, float, and complex<float>#116kandersolar wants to merge 5 commits intoscipy:mainfrom
lambertw with overloads for double, float, and complex<float>#116kandersolar wants to merge 5 commits intoscipy:mainfrom
Conversation
Member
|
Thanks @kandersolar. For testing, the |
Member
|
The windows failures are known and unrelated. You don't have to worry about the formatting issues for now. |
lambertw overloads for double, float, and complex<float>lambertw with overloads for double, float, and complex<float>
kandersolar
added a commit
to kandersolar/xsf
that referenced
this pull request
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds overloads for
lambertwfordouble,float, andcomplex<float>inputs. The implementation follows @steppi's suggested approach in this forum thread: https://discuss.scientific-python.org/t/scipy-special-faster-real-only-versions-of-special-functions/2271/4Please note that this is my first time dealing with modern C++. Please review the code assuming it was written by someone that figured it out as they went :)
I can say at least that it compiles and passes
pixi run tests, which I take to mean that I did not break the existingcomplex<double>path. However, I'll need some guidance with creating tests for the new dtypes. I see there are parquet files with test values, but I'm lost beyond that.