Draft
Conversation
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
LecrisUT
reviewed
Apr 10, 2026
Comment on lines
+159
to
+161
| if original_value is not None or ( | ||
| value is not None and full_key not in config_setting_keys | ||
| ): |
Collaborator
There was a problem hiding this comment.
I don't think the logic here is right, but can't tell exactly what it should be. I think it fails if the user provided if from env-variable.
Comment on lines
-262
to
+277
| static_settings = SourceChain( | ||
| self.static_settings = SourceChain( |
Collaborator
There was a problem hiding this comment.
Maybe what we need here is to break down the self.settings from above to get the EnvSource/ConfSource separate from the *toml_srcs and in the other part check explicitly if the key is in the dynamic_settings.
Collaborator
Author
|
Yes, this was just directly from a model. I think we either need to ensure env-vars are included, or refactor to separate handling a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1261 generated by copilot in VSCode using auto model selection.
Override-only validation checks the TOML-only snapshot instead of the fully merged settings, which stops config-settings from being misclassified as hard-coded pyproject values.