Skip to content

Bump to BVV 0.4.1#824

Open
smlpt wants to merge 6 commits into
scenerygraphics:mainfrom
ekatrukha:testBVVnew
Open

Bump to BVV 0.4.1#824
smlpt wants to merge 6 commits into
scenerygraphics:mainfrom
ekatrukha:testBVVnew

Conversation

@smlpt
Copy link
Copy Markdown
Contributor

@smlpt smlpt commented May 6, 2026

This PR adds support for BigVolumeViewer 0.4.1 in scenery.

@smlpt smlpt added the Dependencies Changes/bumps in dependencies of the project label May 6, 2026
@smlpt smlpt marked this pull request as ready for review May 6, 2026 12:34
@smlpt
Copy link
Copy Markdown
Contributor Author

smlpt commented May 6, 2026

@ekatrukha Thanks for the work on this! I tested your branch and it seems to work fine. Could you please remove the hardcoded path in the BDVExample? Then @skalarproduktraum can merge it.

@ekatrukha
Copy link
Copy Markdown

Hello @smlpt adn @skalarproduktraum,

I didn't finish it completely.

I think it works only with 16-bit inputs now, since it uses only one cache and PBO chain.
In principle, one needs two separate ones (like in BVV now), for 8bit and 16bit, it should be relatively simple.
But I am a bit slow with Kotlin, didn't use it much.
If time allows, I will work on it tomorrow (+ remove the hardcoded example, and try to bring it up to the current state).

@smlpt
Copy link
Copy Markdown
Contributor Author

smlpt commented May 7, 2026

Hello @smlpt adn @skalarproduktraum,

I didn't finish it completely.

I think it works only with 16-bit inputs now, since it uses only one cache and PBO chain. In principle, one needs two separate ones (like in BVV now), for 8bit and 16bit, it should be relatively simple. But I am a bit slow with Kotlin, didn't use it much. If time allows, I will work on it tomorrow (+ remove the hardcoded example, and try to bring it up to the current state).

Thank you! There's no big rush on our side, so if its sometime later this month that would also work.

@ekatrukha
Copy link
Copy Markdown

Hello @smlpt and @skalarproduktraum,

I've added separate caches for 8bit and 16bit multires images. Basically, the logic is very similar to changes in BVV's VolumeRenderer.

I've tested this branch on a single 8-bit or 16-bit multires volume, and it seems to work fine.

  1. Can you please check that it works if one adds both 8bit and 16bit simultaneously? It should be easy to make 8bit BDV XML of t1-head.
  2. And can you please check if adding one or the other volume later also works?

Cheers,
Eugene

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dependencies Changes/bumps in dependencies of the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants