DeferredLighting: Fix energy conservervation for Oren-Nayar model#732
Open
skalarproduktraum wants to merge 1 commit into
Open
DeferredLighting: Fix energy conservervation for Oren-Nayar model#732skalarproduktraum wants to merge 1 commit into
skalarproduktraum wants to merge 1 commit into
Conversation
Contributor
|
I can't really give a proper review here without having something to check the formulas against, sorry. |
moreApi
requested changes
May 27, 2024
Member
moreApi
left a comment
moreApi
left a comment
There was a problem hiding this comment.
pls add a comment to a resource that describes the used algorithm, preferably a url. It should explain what parameters like "CookTorranceVisibility(vec3 N, vec3 V, vec3 H, vec3 L, float roughness) " mean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes energy conservation when using the Oren-Nayar lighting model.