feat(RichTextInput): create new component#6318
Conversation
🦋 Changeset detectedLatest commit: b1b3a8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6318 +/- ##
==========================================
- Coverage 92.58% 92.22% -0.37%
==========================================
Files 533 540 +7
Lines 10063 10284 +221
Branches 3836 3946 +110
==========================================
+ Hits 9317 9484 +167
- Misses 682 729 +47
- Partials 64 71 +7
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
d4b5583 to
8b976b0
Compare
82f8b17 to
82b9a91
Compare
6e9a1dc to
63e7331
Compare
| const status = screen.getByRole('status') | ||
| expect(status).toHaveAttribute('aria-describedby', 'id-test-notice') | ||
| expect(status).toHaveTextContent(successMessage) |
There was a problem hiding this comment.
it's not the status that should have the aria-describedby attribute, it's the element that is described by the status, so in your case the text editor. You have to :
- add an id attribute on the status element
- add an aria-describedby="status-id" attribute on the editor
this way you "link" the status to the editor, and screen readers will read the status when focusing the editor.
As suggested, you can use toHaveAccessibleDescription to check this behavior without reading directly the attributes (test the behavior and not the implementation)
| const status = screen.getByRole('status') | |
| expect(status).toHaveAttribute('aria-describedby', 'id-test-notice') | |
| expect(status).toHaveTextContent(successMessage) | |
| const doc = screen.getByLabelText<HTMLDivElement>('Test') | |
| expect(doc).toHaveAccessibleDescription(successMessage) | |
| expect(screen.getByText(successMessage)).toHaveRole('status') |
use this same syntax for the other tests below
| onFocus={onFocus} | ||
| /> | ||
| {error ? ( | ||
| <AlertCircleIcon |
There was a problem hiding this comment.
The icon seems to me you're in the right place, we can see together if you can reproduce it.
d940382 to
91f9ca8
Compare
e5a2e2a to
675882b
Compare


Summary
Type
Summarize concisely:
What is expected?
RichTextInput: create componentRichTextInputandRichTextInputFieldThe following changes were made:
(Describe what you did)
Relevant logs and/or screenshots